Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/browser_watcher/exit_funnel_win.cc

Issue 1410333006: Enough hacks to make wstring printfs unneeded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/util/shell_util.cc ('K') | « components/browser_watcher/exit_code_watcher_win.cc ('k') | components/crash/content/app/breakpad_win.cc » ('j') | content/browser/accessibility/accessibility_tree_formatter_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/exit_funnel_win.cc
diff --git a/components/browser_watcher/exit_funnel_win.cc b/components/browser_watcher/exit_funnel_win.cc
index 5a817684fc734ad436505612b2ebfa534737bb94..3fce96a8f8cb62ecf6423508bc96c212253f8ba6 100644
--- a/components/browser_watcher/exit_funnel_win.cc
+++ b/components/browser_watcher/exit_funnel_win.cc
@@ -38,8 +38,9 @@ bool ExitFunnel::InitImpl(const base::char16* registry_path,
base::ProcessId pid,
base::Time creation_time) {
base::string16 key_name = registry_path;
- base::StringAppendF(
- &key_name, L"\\%d-%lld", pid, creation_time.ToInternalValue());
+ // Safe
+ //base::StringAppendF(
+ // &key_name, L"\\%d-%lld", pid, creation_time.ToInternalValue());
LONG res = key_.Create(HKEY_CURRENT_USER, key_name.c_str(), KEY_SET_VALUE);
if (res != ERROR_SUCCESS) {
« chrome/installer/util/shell_util.cc ('K') | « components/browser_watcher/exit_code_watcher_win.cc ('k') | components/crash/content/app/breakpad_win.cc » ('j') | content/browser/accessibility/accessibility_tree_formatter_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698