Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410313005: Move most codegen registrations into WorldImpact. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move most codegen registrations into WorldImpact. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/8688d297c58c102b60911dd1f7c808ac87200569

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -116 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 7 chunks +57 lines, -101 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in backend.dart
5 years, 1 month ago (2015-10-28 10:51:44 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1410313005/diff/1/pkg/compiler/lib/src/js_backend/codegen/glue.dart File pkg/compiler/lib/src/js_backend/codegen/glue.dart (right): https://codereview.chromium.org/1410313005/diff/1/pkg/compiler/lib/src/js_backend/codegen/glue.dart#newcode246 pkg/compiler/lib/src/js_backend/codegen/glue.dart:246: /*void registerIsCheck(DartType type, Registry registry) { Debug comment?
5 years, 1 month ago (2015-10-28 11:32:24 UTC) #3
Johnni Winther
https://codereview.chromium.org/1410313005/diff/1/pkg/compiler/lib/src/js_backend/codegen/glue.dart File pkg/compiler/lib/src/js_backend/codegen/glue.dart (right): https://codereview.chromium.org/1410313005/diff/1/pkg/compiler/lib/src/js_backend/codegen/glue.dart#newcode246 pkg/compiler/lib/src/js_backend/codegen/glue.dart:246: /*void registerIsCheck(DartType type, Registry registry) { On 2015/10/28 11:32:24, ...
5 years, 1 month ago (2015-10-28 12:32:56 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-10-28 12:54:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8688d297c58c102b60911dd1f7c808ac87200569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698