Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1410313005: Move most codegen registrations into WorldImpact. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 5348fc447bc31301a0c44a047308462ef8948fa4..608ab9b84da0c3e6a3dcd94a0a610c4a72836d09 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -360,7 +360,8 @@ class CodeGenerator extends tree_ir.StatementVisitor
List<js.Expression> typeArguments = visitExpressionList(node.typeArguments);
DartType type = node.type;
if (type is InterfaceType) {
- glue.registerIsCheck(type, registry);
+ registry.registerIsCheck(type);
+ //glue.registerIsCheck(type, registry);
ClassElement clazz = type.element;
if (glue.isStringClass(clazz)) {
@@ -405,7 +406,8 @@ class CodeGenerator extends tree_ir.StatementVisitor
function,
<js.Expression>[value, isT, typeArgumentArray, asT]);
} else if (type is TypeVariableType || type is FunctionType) {
- glue.registerIsCheck(type, registry);
+ registry.registerIsCheck(type);
+ //glue.registerIsCheck(type, registry);
Element function = node.isTypeTest
? glue.getCheckSubtypeOfRuntimeType()
@@ -426,7 +428,8 @@ class CodeGenerator extends tree_ir.StatementVisitor
js.Expression object = visitExpression(node.object);
DartType dartType = node.dartType;
assert(dartType.isInterfaceType);
- glue.registerIsCheck(dartType, registry);
+ registry.registerIsCheck(dartType);
+ //glue.registerIsCheck(dartType, registry);
js.Expression property = glue.getTypeTestTag(dartType);
return js.js(r'#.#', [object, property]);
}
@@ -716,7 +719,7 @@ class CodeGenerator extends tree_ir.StatementVisitor
@override
js.Expression visitInterceptor(tree_ir.Interceptor node) {
- glue.registerUseInterceptorInCodegen();
+ registry.registerUseInterceptor();
registry.registerSpecializedGetInterceptor(node.interceptedClasses);
js.Name helperName = glue.getInterceptorName(node.interceptedClasses);
js.Expression globalHolder = glue.getInterceptorLibrary();
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend_impact.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698