Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1410313002: Revert of Revalidate using the same Resource, attempt #3 (Closed)

Created:
5 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Nate Chapin, Mike West
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, krit, f(malita), fs, gavinp+loader_chromium.org, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revalidate using the same Resource, attempt #3 (patchset #2 id:20001 of https://codereview.chromium.org/1398523004/ ) Reason for revert: Seems to have caused assertion failures on http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29?numbuilds=200 as described on the original CL. Original issue's description: > Revalidate using the same Resource, attempt #3 > > Currently, when we perform a revalidation, we create a new resource and put it in the MemoryCache in place of the resource being revalidated. If the revalidation results in a 304, we silently swap all of the clients of the revalidation to the now-revalidated resource and swap which Resource is in the MemoryCache. > > This changes the behavior to use the existing resource to revalidate itself, which simplifies the logic quite a bit. It also gives us the option of removing ResourcePtr (which is used to implement the silent client swap in the 304 case) and make Resources simply RefCounted in a future change. > > BUG= > > Committed: https://crrev.com/71adea27213b2268bda765abccd5a3bf9517b860 > Cr-Commit-Position: refs/heads/master@{#354615} TBR=mkwst@chromium.org,japhet@chromium.org BUG= Committed: https://crrev.com/de1ba5f46e2227224a245a54f8de2b85231c55ff Cr-Commit-Position: refs/heads/master@{#354721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -148 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FontResource.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 4 chunks +2 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 1 chunk +19 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 9 chunks +21 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 20 chunks +148 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 4 chunks +13 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ken Russell (switch to Gerrit)
Created Revert of Revalidate using the same Resource, attempt #3
5 years, 2 months ago (2015-10-18 23:24:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410313002/1
5 years, 2 months ago (2015-10-18 23:25:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 03:15:28 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 03:16:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de1ba5f46e2227224a245a54f8de2b85231c55ff
Cr-Commit-Position: refs/heads/master@{#354721}

Powered by Google App Engine
This is Rietveld 408576698