Add non-script SharedFunctionInfos to the Iterator.

Add non-script SharedFunctionInfos to the Iterator.

BUG=

Committed: https://crrev.com/15b4804cdfac07a716def89e755c8a041447fa24
Cr-Commit-Position: refs/heads/master@{#31597}

[mvstanton, 2015-10-26 10:44:05]

Patchset #2 (id:20001) has been deleted

[mvstanton, 2015-10-26 10:44:11]

Patchset #1 (id:1) has been deleted

[mvstanton, 2015-10-26 10:46:03]

mvstanton@chromium.org changed reviewers:
+ mstarzinger@chromium.org, yangguo@chromium.org

[mvstanton, 2015-10-26 10:46:04]

Hi Yang, hi Michael,
Here is the complete iterator support we discussed.
Michael if you could look at heap/*, and Yang the rest?
Thanks,
--Michael

[Yang, 2015-10-26 12:26:09]

On 2015/10/26 10:46:04, mvstanton wrote:
> Hi Yang, hi Michael,
> Here is the complete iterator support we discussed.
> Michael if you could look at heap/*, and Yang the rest?
> Thanks,
> --Michael

lgtm!

[Michael Starzinger, 2015-10-27 09:45:52]

LGTM. Looking good, I like it, just nits.

https://codereview.chromium.org/1410223007/diff/40001/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/1410223007/diff/40001/src/factory.cc#newcode2168
src/factory.cc:2168: return share;
nit: Empty newline before return.

https://codereview.chromium.org/1410223007/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1410223007/diff/40001/src/heap/heap.h#newcode824
src/heap/heap.h:824: inline void UpdateNoScriptSharedFunctionInfos(Object*
object);
This is a root-set setter, please move it into "Root set access" section and
follow the naming convention there (i.e. SetRootNoScriptSharedFunctionInfos).

[mvstanton, 2015-10-27 10:58:24]

Right on, thanks!

https://codereview.chromium.org/1410223007/diff/40001/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/1410223007/diff/40001/src/factory.cc#newcode2168
src/factory.cc:2168: return share;
On 2015/10/27 09:45:51, Michael Starzinger wrote:
> nit: Empty newline before return.

Done.

https://codereview.chromium.org/1410223007/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1410223007/diff/40001/src/heap/heap.h#newcode824
src/heap/heap.h:824: inline void UpdateNoScriptSharedFunctionInfos(Object*
object);
On 2015/10/27 09:45:51, Michael Starzinger wrote:
> This is a root-set setter, please move it into "Root set access" section and
> follow the naming convention there (i.e. SetRootNoScriptSharedFunctionInfos).

Done.

[mvstanton, 2015-10-27 10:59:22]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-10-27 10:59:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1410223007/#ps80001
(title: "REBASE.")

[commit-bot: I haz the power, 2015-10-27 10:59:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1410223007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1410223007/80001

[commit-bot: I haz the power, 2015-10-27 11:40:37]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-27 11:41:08]

Patchset 3 (id:??) landed as
https://crrev.com/15b4804cdfac07a716def89e755c8a041447fa24
Cr-Commit-Position: refs/heads/master@{#31597}