Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: test/cctest/test-heap.cc

Issue 1410223007: Add non-script SharedFunctionInfos to the Iterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index 7f7c8ebf2bb690ac769e2ea4d18227a1d1db6ad7..217ac0123eb3e96040cebb2ebfd358d197922285 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -6227,18 +6227,7 @@ TEST(SharedFunctionInfoIterator) {
HeapIterator it(heap);
for (HeapObject* obj = it.next(); obj != NULL; obj = it.next()) {
if (!obj->IsSharedFunctionInfo()) continue;
- // Shared function infos without a script (API functions or C++ builtins)
- // are not returned by the iterator because they are not created from a
- // script. They are not interesting for type feedback vector anyways.
-
- // TODO(mvstanton): There are builtins that use type feedback vectors,
- // consider adding these to the iterator.
- SharedFunctionInfo* shared = SharedFunctionInfo::cast(obj);
- if (shared->script()->IsUndefined()) {
- CHECK(shared->native() || shared->feedback_vector()->is_empty());
- } else {
- sfi_count++;
- }
+ sfi_count++;
}
}
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698