Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Issue 1410123009: [turbofan] Use cmn on ARM64 for negated rhs cmp (Closed)

Created:
5 years, 1 month ago by martyn.capewell
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use cmn on ARM64 for negated rhs cmp Use compare-negate instruction if the right-hand input to a compare is a negate operation. BUG= Committed: https://crrev.com/eb991c66e545a2c1c322450ffc674f6ced3bc375 Cr-Commit-Position: refs/heads/master@{#31866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -7 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +26 lines, -5 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
martyn.capewell
I'm not entirely happy with the way in which I duplicate the input to the ...
5 years, 1 month ago (2015-11-06 18:25:33 UTC) #2
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-07 07:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410123009/1
5 years, 1 month ago (2015-11-07 07:02:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-07 07:20:06 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 07:20:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb991c66e545a2c1c322450ffc674f6ced3bc375
Cr-Commit-Position: refs/heads/master@{#31866}

Powered by Google App Engine
This is Rietveld 408576698