Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1410123003: Rename "test" ozone platform to "headless" (Closed)

Created:
5 years, 1 month ago by altimin
Modified:
5 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "test" ozone platform to "headless" This platform normally has no graphical output or user input support and has been used for running tests. Rename it to "headless" to describe what it does rather than what we've been using it for. BUG=546953 Committed: https://crrev.com/5abfd72765d29f36b577cdbb91ed7cfabc7560a7 Cr-Commit-Position: refs/heads/master@{#359336}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Changes according to Sami's notes #

Patch Set 3 : Renamed egltest => eglheadless, test => headless #

Total comments: 6

Patch Set 4 : Changes according to spang's comments #

Total comments: 4

Patch Set 5 : Changes according to review #

Total comments: 1

Patch Set 6 : Final fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -731 lines) Patch
M build/common.gypi View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chromecast/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chromecast/chromecast_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M media/ozone/media_ozone_platform.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/BUILD.gn View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ui/ozone/ozone.gni View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A ui/ozone/platform/headless/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
A + ui/ozone/platform/headless/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/ozone/platform/headless/client_native_pixmap_factory_headless.h View 1 chunk +17 lines, -0 lines 0 comments Download
A + ui/ozone/platform/headless/client_native_pixmap_factory_headless.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/ozone/platform/headless/headless.gypi View 1 2 3 4 2 chunks +13 lines, -13 lines 0 comments Download
A + ui/ozone/platform/headless/headless_surface_factory.h View 1 2 2 chunks +11 lines, -10 lines 0 comments Download
A + ui/ozone/platform/headless/headless_surface_factory.cc View 1 2 3 4 chunks +12 lines, -9 lines 0 comments Download
A + ui/ozone/platform/headless/headless_window.h View 1 2 3 4 3 chunks +12 lines, -11 lines 0 comments Download
A ui/ozone/platform/headless/headless_window.cc View 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
A + ui/ozone/platform/headless/headless_window_manager.h View 1 2 3 chunks +13 lines, -12 lines 0 comments Download
A + ui/ozone/platform/headless/headless_window_manager.cc View 1 2 2 chunks +11 lines, -10 lines 0 comments Download
A + ui/ozone/platform/headless/ozone_platform_headless.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + ui/ozone/platform/headless/ozone_platform_headless.cc View 1 2 7 chunks +25 lines, -25 lines 0 comments Download
D ui/ozone/platform/test/BUILD.gn View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D ui/ozone/platform/test/DEPS View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D ui/ozone/platform/test/client_native_pixmap_factory_test.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D ui/ozone/platform/test/client_native_pixmap_factory_test.cc View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D ui/ozone/platform/test/ozone_platform_test.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D ui/ozone/platform/test/ozone_platform_test.cc View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
D ui/ozone/platform/test/test.gypi View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D ui/ozone/platform/test/test_surface_factory.h View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
D ui/ozone/platform/test/test_surface_factory.cc View 1 2 1 chunk +0 lines, -88 lines 0 comments Download
D ui/ozone/platform/test/test_window.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D ui/ozone/platform/test/test_window.cc View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
D ui/ozone/platform/test/test_window_manager.h View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D ui/ozone/platform/test/test_window_manager.cc View 1 2 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 51 (23 generated)
Sami
Looks pretty good! https://codereview.chromium.org/1410123003/diff/1/ui/ozone/ozone.gni File ui/ozone/ozone.gni (right): https://codereview.chromium.org/1410123003/diff/1/ui/ozone/ozone.gni#newcode46 ui/ozone/ozone.gni:46: ozone_platform = "headless" This means we ...
5 years, 1 month ago (2015-10-26 16:47:08 UTC) #3
altimin
https://codereview.chromium.org/1410123003/diff/1/ui/ozone/ozone.gni File ui/ozone/ozone.gni (right): https://codereview.chromium.org/1410123003/diff/1/ui/ozone/ozone.gni#newcode46 ui/ozone/ozone.gni:46: ozone_platform = "headless" On 2015/10/26 16:47:07, Sami wrote: > ...
5 years, 1 month ago (2015-10-26 17:24:21 UTC) #4
Sami
Thanks, non-owner lgtm.
5 years, 1 month ago (2015-10-26 18:16:43 UTC) #5
Sami
Btw, are there any tests we should be duplicating?
5 years, 1 month ago (2015-10-26 18:17:19 UTC) #6
altimin
+tiago.vignatti Renamed ozone platforms instead of creating new one as suggested in https://code.google.com/p/chromium/issues/detail?id=546953. PTAL.
5 years, 1 month ago (2015-10-29 15:17:53 UTC) #9
altimin
+tiago.vignatti Renamed ozone platforms instead of creating new one as suggested in https://code.google.com/p/chromium/issues/detail?id=546953. PTAL.
5 years, 1 month ago (2015-10-29 15:17:53 UTC) #10
altimin
+ dpranke@ Can you please take a look at changes in build/common.gypi?
5 years, 1 month ago (2015-10-29 15:27:03 UTC) #13
spang
https://codereview.chromium.org/1410123003/diff/40001/ui/ozone/BUILD.gn File ui/ozone/BUILD.gn (right): https://codereview.chromium.org/1410123003/diff/40001/ui/ozone/BUILD.gn#newcode17 ui/ozone/BUILD.gn:17: if (ozone_platform_eglheadless) { Let's leave egltest alone - although ...
5 years, 1 month ago (2015-10-29 15:46:35 UTC) #14
altimin
PTAL https://codereview.chromium.org/1410123003/diff/40001/ui/ozone/BUILD.gn File ui/ozone/BUILD.gn (right): https://codereview.chromium.org/1410123003/diff/40001/ui/ozone/BUILD.gn#newcode17 ui/ozone/BUILD.gn:17: if (ozone_platform_eglheadless) { On 2015/10/29 15:46:35, spang wrote: ...
5 years, 1 month ago (2015-10-29 16:06:10 UTC) #15
dnicoara
+ halliwell@ The cast team had been using the test platform. You may need to ...
5 years, 1 month ago (2015-10-29 16:34:37 UTC) #17
spang
otherwise lg, let's wait for Luke to see if cast depends on the name anywhere ...
5 years, 1 month ago (2015-10-29 17:16:18 UTC) #18
halliwell
On 2015/10/29 17:16:18, spang wrote: > otherwise lg, let's wait for Luke to see if ...
5 years, 1 month ago (2015-10-29 18:59:37 UTC) #19
halliwell
On 2015/10/29 18:59:37, halliwell wrote: > On 2015/10/29 17:16:18, spang wrote: > > otherwise lg, ...
5 years, 1 month ago (2015-10-29 19:02:52 UTC) #20
spang
On 2015/10/29 19:02:52, halliwell wrote: > On 2015/10/29 18:59:37, halliwell wrote: > > On 2015/10/29 ...
5 years, 1 month ago (2015-10-29 19:31:48 UTC) #24
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-29 21:03:45 UTC) #26
altimin
PTAL +spang@: Looks like you've been removed from reviewers, don't know why, adding you back. ...
5 years, 1 month ago (2015-11-02 18:45:25 UTC) #28
spang
lgtm
5 years, 1 month ago (2015-11-02 18:47:42 UTC) #29
halliwell
On 2015/11/02 18:47:42, spang wrote: > lgtm chromecast/ lgtm
5 years, 1 month ago (2015-11-02 20:19:39 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410123003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410123003/80001
5 years, 1 month ago (2015-11-12 11:33:18 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/117887)
5 years, 1 month ago (2015-11-12 11:41:07 UTC) #38
altimin
On 2015/11/12 11:41:07, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-12 11:47:55 UTC) #40
reed1
lgtm
5 years, 1 month ago (2015-11-12 14:41:05 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410123003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410123003/80001
5 years, 1 month ago (2015-11-12 14:42:11 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/87528)
5 years, 1 month ago (2015-11-12 15:11:52 UTC) #45
spang
https://codereview.chromium.org/1410123003/diff/80001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1410123003/diff/80001/build/common.gypi#newcode2390 build/common.gypi:2390: 'ozone_platform%': 'test', You need to change this part too.
5 years, 1 month ago (2015-11-12 15:28:49 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410123003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410123003/100001
5 years, 1 month ago (2015-11-12 16:09:50 UTC) #49
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-11-12 18:41:08 UTC) #50
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:08:10 UTC) #51
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5abfd72765d29f36b577cdbb91ed7cfabc7560a7
Cr-Commit-Position: refs/heads/master@{#359336}

Powered by Google App Engine
This is Rietveld 408576698