Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1410113008: [Interpreter] Add test for sloppy mode receiver replacement. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add test for sloppy mode receiver replacement. Adds a test that the receiver for sloppy mode functions is replaced with the global proxy when called with an undefined receiever. BUG=v8:4280 LOG=N Committed: https://crrev.com/7c160afd49ebc71f87bf0a2d7d919bb67247d23c Cr-Commit-Position: refs/heads/master@{#31854}

Patch Set 1 #

Patch Set 2 : Rebase to include Toon's sloppy receiver change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -24 lines) Patch
M src/arm/builtins-arm.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410113008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410113008/1
5 years, 1 month ago (2015-11-05 14:50:03 UTC) #2
rmcilroy
Benedikt, could you please take a look? If the approach looks OK I'll port to ...
5 years, 1 month ago (2015-11-05 14:50:26 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/9630) v8_linux_arm_rel on ...
5 years, 1 month ago (2015-11-05 14:52:06 UTC) #6
Benedikt Meurer
I guess Toons latest changes make this obsolete?
5 years, 1 month ago (2015-11-06 03:51:03 UTC) #7
rmcilroy
On 2015/11/06 03:51:03, Benedikt Meurer wrote: > I guess Toons latest changes make this obsolete? ...
5 years, 1 month ago (2015-11-06 08:18:02 UTC) #8
Benedikt Meurer
On 2015/11/06 08:18:02, rmcilroy wrote: > On 2015/11/06 03:51:03, Benedikt Meurer wrote: > > I ...
5 years, 1 month ago (2015-11-06 08:19:22 UTC) #9
rmcilroy
On 2015/11/06 08:19:22, Benedikt Meurer wrote: > On 2015/11/06 08:18:02, rmcilroy wrote: > > On ...
5 years, 1 month ago (2015-11-06 09:28:15 UTC) #11
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-11-06 10:39:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410113008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410113008/20001
5 years, 1 month ago (2015-11-06 10:56:21 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 11:13:31 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 11:14:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c160afd49ebc71f87bf0a2d7d919bb67247d23c
Cr-Commit-Position: refs/heads/master@{#31854}

Powered by Google App Engine
This is Rietveld 408576698