Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1414883011: Remove receiver conversion from function prologue (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove receiver conversion from function prologue Depends on https://codereview.chromium.org/1407373007/ After that CL, all receiver conversion is handled by the call builtin. BUG= Committed: https://crrev.com/4ab1b05d5ec15f25085383e34e3b326bdbf990fc Cr-Commit-Position: refs/heads/master@{#31826}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add requested asserts #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -233 lines) Patch
M src/bailout-reason.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +4 lines, -14 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +4 lines, -13 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +4 lines, -16 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +6 lines, -15 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +7 lines, -14 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +4 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Toon Verwaest
ptal
5 years, 1 month ago (2015-11-05 09:44:54 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1414883011/diff/1/src/full-codegen/x64/full-codegen-x64.cc File src/full-codegen/x64/full-codegen-x64.cc (left): https://codereview.chromium.org/1414883011/diff/1/src/full-codegen/x64/full-codegen-x64.cc#oldcode110 src/full-codegen/x64/full-codegen-x64.cc:110: if (info->MustReplaceUndefinedReceiverWithGlobalProxy()) { Can we have a check here ...
5 years, 1 month ago (2015-11-05 09:47:54 UTC) #5
Michael Starzinger
LGTM. Yes! So much, yes!
5 years, 1 month ago (2015-11-05 09:49:09 UTC) #7
Benedikt Meurer
LGTM. Now. Yes. Please!
5 years, 1 month ago (2015-11-05 11:16:59 UTC) #8
Benedikt Meurer
nice. Still LGTM!
5 years, 1 month ago (2015-11-05 12:08:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414883011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414883011/40001
5 years, 1 month ago (2015-11-05 12:55:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-05 13:23:17 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 13:23:59 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ab1b05d5ec15f25085383e34e3b326bdbf990fc
Cr-Commit-Position: refs/heads/master@{#31826}

Powered by Google App Engine
This is Rietveld 408576698