Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1410043003: Declare PDF_GetStandardFontName() in the header. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/include/fxge/fx_font.h ('k') | core/src/fpdfapi/fpdf_font/fpdf_font.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
index a3281999feba156fa79427993097ae63e9d50785..dc79de687d20c778f176027f0a15d8fd70999076 100644
--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp
@@ -1105,15 +1105,15 @@ CPDF_Dictionary* CPDF_Document::CreateNewPage(int iPage) {
}
return pDict;
}
-int _PDF_GetStandardFontName(CFX_ByteString& name);
+
CPDF_Font* CPDF_Document::AddStandardFont(const FX_CHAR* font,
CPDF_FontEncoding* pEncoding) {
CFX_ByteString name(font, -1);
Tom Sepez 2015/10/16 21:32:33 nit: the -1 isn't needed, the one-arg form hits st
Lei Zhang 2015/10/16 21:34:52 There's more of them. I'll fix them all in another
- if (_PDF_GetStandardFontName(name) < 0) {
- return NULL;
- }
+ if (PDF_GetStandardFontName(&name) < 0)
+ return nullptr;
return GetPageData()->GetStandardFont(name, pEncoding);
}
+
void CPDF_Document::DeletePage(int iPage) {
CPDF_Dictionary* pRoot = GetRoot();
if (pRoot == NULL) {
« no previous file with comments | « core/include/fxge/fx_font.h ('k') | core/src/fpdfapi/fpdf_font/fpdf_font.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698