Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141003013: Clean-up: Removes obsolete methods in gfx::Canvas. (Closed)

Created:
6 years, 11 months ago by Yuki
Modified:
6 years, 10 months ago
CC:
chromium-reviews, sadrul, tfarina, dcheng, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Clean-up: Removes obsolete methods in gfx::Canvas. Removes unused obsolete methods in gfx::Canvas. I'm planning to remove gfx::Canvas::GetStringWidth(text, font) in a separate CL when I finish rewriting the client code. BUG=265485 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247980

Patch Set 1 #

Patch Set 2 : Synced. #

Patch Set 3 : Synced. #

Patch Set 4 : Synced. #

Patch Set 5 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -123 lines) Patch
M ui/gfx/canvas.h View 10 chunks +7 lines, -53 lines 0 comments Download
M ui/gfx/canvas.cc View 3 chunks +0 lines, -64 lines 0 comments Download
M ui/gfx/canvas_unittest.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Yuki
Could you guys review this CL?
6 years, 11 months ago (2014-01-27 05:12:40 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 11 months ago (2014-01-27 15:04:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/141003013/120001
6 years, 10 months ago (2014-01-28 18:21:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-01-28 20:39:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/141003013/120001
6 years, 10 months ago (2014-01-29 02:53:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=144233
6 years, 10 months ago (2014-01-29 05:38:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/141003013/160001
6 years, 10 months ago (2014-01-30 13:02:57 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, content_browsertests, interactive_ui_tests, nacl_integration, net_unittests, ...
6 years, 10 months ago (2014-01-30 13:32:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/141003013/160001
6 years, 10 months ago (2014-01-30 13:35:44 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=254213
6 years, 10 months ago (2014-01-30 14:44:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/141003013/160001
6 years, 10 months ago (2014-01-30 14:47:09 UTC) #11
commit-bot: I haz the power
Change committed as 247980
6 years, 10 months ago (2014-01-30 17:42:45 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 17:42:52 UTC) #13
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698