Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2142)

Unified Diff: chrome/browser/sync/glue/sync_backend_host.h

Issue 1410013008: [Sync] Remove some http-related chrome deps from SyncBackendHostImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary includes/forward decls. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/sync_backend_host.h
diff --git a/chrome/browser/sync/glue/sync_backend_host.h b/chrome/browser/sync/glue/sync_backend_host.h
index f65ffa1a1de2ddff4ffc4b1bc26b217087b1c60e..f5ac43fc0bcf1e2b0cb2c9019a20a1a28aba5b95 100644
--- a/chrome/browser/sync/glue/sync_backend_host.h
+++ b/chrome/browser/sync/glue/sync_backend_host.h
@@ -28,7 +28,8 @@ class MessageLoop;
}
namespace syncer {
-class NetworkResources;
+class CancelationSignal;
+class HttpPostProviderFactory;
class SyncManagerFactory;
class UnrecoverableErrorHandler;
}
@@ -47,6 +48,8 @@ namespace browser_sync {
class SyncBackendHost : public sync_driver::BackendDataTypeConfigurer {
public:
typedef syncer::SyncStatus Status;
+ typedef base::Callback<scoped_ptr<syncer::HttpPostProviderFactory>(
+ syncer::CancelationSignal*)> HttpPostProviderFactoryGetter;
// Stubs used by implementing classes.
SyncBackendHost();
@@ -72,7 +75,7 @@ class SyncBackendHost : public sync_driver::BackendDataTypeConfigurer {
const syncer::WeakHandle<syncer::UnrecoverableErrorHandler>&
unrecoverable_error_handler,
const base::Closure& report_unrecoverable_error_function,
- syncer::NetworkResources* network_resources,
+ const HttpPostProviderFactoryGetter& get_http_post_provider_factory,
Nicolas Zea 2015/10/27 20:41:42 nit: prefer calling this http_post_provider_factor
maxbogue 2015/10/27 23:53:08 Ah, my habit when naming function vars is verbs, b
scoped_ptr<syncer::SyncEncryptionHandler::NigoriState>
saved_nigori_state) = 0;
« no previous file with comments | « no previous file | chrome/browser/sync/glue/sync_backend_host_impl.h » ('j') | chrome/browser/sync/profile_sync_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698