[Sync] Remove some http-related chrome deps from SyncBackendHostImpl.

chrome/browser/sync/glue/sync_backend_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SYNC_BACKEND_HOST_H_
 #define CHROME_BROWSER_SYNC_GLUE_SYNC_BACKEND_HOST_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 10 matching lines @@
 #include "sync/internal_api/public/sync_manager_factory.h"
 #include "sync/internal_api/public/util/weak_handle.h"
 
 class GURL;
 
 namespace base {
 class MessageLoop;
 }
 
 namespace syncer {
-class NetworkResources;
+class CancelationSignal;
+class HttpPostProviderFactory;
 class SyncManagerFactory;
 class UnrecoverableErrorHandler;
 }
 
 namespace sync_driver {
 class ChangeProcessor;
 class SyncFrontend;
 }
 
 namespace browser_sync {
 
 // An API to "host" the top level SyncAPI element.
 //
 // This class handles dispatch of potentially blocking calls to appropriate
 // threads and ensures that the SyncFrontend is only accessed on the UI loop.
 class SyncBackendHost : public sync_driver::BackendDataTypeConfigurer {
  public:
   typedef syncer::SyncStatus Status;
+  typedef base::Callback<scoped_ptr<syncer::HttpPostProviderFactory>(
+      syncer::CancelationSignal*)> HttpPostProviderFactoryGetter;
 
   // Stubs used by implementing classes.
   SyncBackendHost();
   ~SyncBackendHost() override;
 
   // Called on the frontend's thread to kick off asynchronous initialization.
   // Optionally deletes the "Sync Data" folder during init in order to make
   // sure we're starting fresh.
   //
   // |saved_nigori_state| is optional nigori state to restore from a previous
   // backend instance. May be null.
   virtual void Initialize(
       sync_driver::SyncFrontend* frontend,
       scoped_ptr<base::Thread> sync_thread,
       const scoped_refptr<base::SingleThreadTaskRunner>& db_thread,
       const scoped_refptr<base::SingleThreadTaskRunner>& file_thread,
       const syncer::WeakHandle<syncer::JsEventHandler>& event_handler,
       const GURL& service_url,
       const std::string& sync_user_agent,
       const syncer::SyncCredentials& credentials,
       bool delete_sync_data_folder,
       scoped_ptr<syncer::SyncManagerFactory> sync_manager_factory,
       const syncer::WeakHandle<syncer::UnrecoverableErrorHandler>&
           unrecoverable_error_handler,
       const base::Closure& report_unrecoverable_error_function,
-      syncer::NetworkResources* network_resources,
+      const HttpPostProviderFactoryGetter& get_http_post_provider_factory,

[Nicolas Zea, 2015/10/27 20:41:42]

nit: prefer calling this http_post_provider_factory_getter (we typically have
the name describe what it is, not be a verb about what it would do).

[maxbogue, 2015/10/27 23:53:08]

Ah, my habit when naming function vars is verbs, but that probably makes more
sense in other languages. Done.

       scoped_ptr<syncer::SyncEncryptionHandler::NigoriState>
           saved_nigori_state) = 0;
 
   // Called on the frontend's thread to trigger a refresh.
   virtual void TriggerRefresh(const syncer::ModelTypeSet& types) = 0;
 
   // Called on the frontend's thread to update SyncCredentials.
   virtual void UpdateCredentials(
       const syncer::SyncCredentials& credentials) = 0;
 
@@ skipping 137 matching lines @@
   // See SyncManager::ClearServerData.
   virtual void ClearServerData(
       const syncer::SyncManager::ClearServerDataCallback& callback) = 0;
 
   DISALLOW_COPY_AND_ASSIGN(SyncBackendHost);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SYNC_BACKEND_HOST_H_