Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1409993005: Revert of Cherry pick disabled unicode compatibility decomposition into HarfBuzz (Closed)

Created:
5 years, 2 months ago by Justin Novosad
Modified:
5 years, 2 months ago
Reviewers:
drott, eae, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cherry pick disabled unicode compatibility decomposition into HarfBuzz (patchset #1 id:1 of https://codereview.chromium.org/1416013004/ ) Reason for revert: This change is causing bllink layout test failures on multiple platforms. Judging from the diffs, this looks like a regression, not just something that needs rebaselining. fast/text/unicode-fallback-font.html (windows only) fast/text/midword-break-before-surrogate-pair.html (windows only) svg/text/non-bmp-positioning-lists.svg Affected platforms: Mac 10.6 only Win XP, 7 and 10 Linux 64, 32 and Trusty Original issue's description: > Cherry pick disabled unicode compatibility decomposition into HarfBuzz > > HarfBuzz commit f6799700404c49ae0 disables unicode compatibility > decomposition, avoiding undesirable substitutions and allowing Blink > to fall back to system fonts for mathematical symbols and the > like. Cherry-picking this into our HarfBuzz version in order to be able > to land shaper driven segmentation. > > BUG=546454 > R=behdad,eae > > Committed: https://crrev.com/c6da2801d9e36a9f2bb5acf4e3c492c8f0680ad4 > Cr-Commit-Position: refs/heads/master@{#355551} TBR=behdad@chromium.org,eae@chromium.org,drott@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546454 Committed: https://crrev.com/4bd26388c7080027f1529dbee9730ed7f309cbbe Cr-Commit-Position: refs/heads/master@{#355637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Justin Novosad
Created Revert of Cherry pick disabled unicode compatibility decomposition into HarfBuzz
5 years, 2 months ago (2015-10-22 20:46:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409993005/1
5 years, 2 months ago (2015-10-22 20:47:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 20:48:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4bd26388c7080027f1529dbee9730ed7f309cbbe Cr-Commit-Position: refs/heads/master@{#355637}
5 years, 2 months ago (2015-10-22 20:49:29 UTC) #4
eae
5 years, 2 months ago (2015-10-22 21:54:55 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698