Remove unused error variable from CFX_Font::AdjustMMParams

core/src/fxge/ge/fx_ge_text.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxge/fx_freetype.h"
 #include "../../../include/fxcodec/fx_codec.h"
 #include "text_int.h"
@@ skipping 1383 matching lines @@
     coords[0] = FXFT_Get_MM_Axis_Def(FXFT_Get_MM_Axis(pMasters, 0)) / 65536;
   } else {
     coords[0] = weight;
   }
   if (dest_width == 0) {
     coords[1] = FXFT_Get_MM_Axis_Def(FXFT_Get_MM_Axis(pMasters, 1)) / 65536;
   } else {
     int min_param = FXFT_Get_MM_Axis_Min(FXFT_Get_MM_Axis(pMasters, 1)) / 65536;
     int max_param = FXFT_Get_MM_Axis_Max(FXFT_Get_MM_Axis(pMasters, 1)) / 65536;
     coords[1] = min_param;
-    int error = FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);

[Lei Zhang, 2015/10/22 18:53:40]

Uh, we had plans to actually check |error|. See
https://code.google.com/p/pdfium/issues/detail?id=156 , which I never got around
to fixing.

[Oliver Chang, 2015/10/22 18:58:55]

Sure, I wasn't sure if it was worth rewriting the logic in a way to do the
actual error checking here.

-    error = FXFT_Load_Glyph(
+    (void)FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);
+    (void)FXFT_Load_Glyph(
         m_Face, glyph_index,
         FXFT_LOAD_NO_SCALE | FXFT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH);
     int min_width = FXFT_Get_Glyph_HoriAdvance(m_Face) * 1000 /
                     FXFT_Get_Face_UnitsPerEM(m_Face);
     coords[1] = max_param;
-    error = FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);
-    error = FXFT_Load_Glyph(
+    (void)FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);
+    (void)FXFT_Load_Glyph(
         m_Face, glyph_index,
         FXFT_LOAD_NO_SCALE | FXFT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH);
     int max_width = FXFT_Get_Glyph_HoriAdvance(m_Face) * 1000 /
                     FXFT_Get_Face_UnitsPerEM(m_Face);
     if (max_width == min_width) {
+      FXFT_Free(m_Face, pMasters);
       return;
     }
     int param = min_param +
                 (max_param - min_param) * (dest_width - min_width) /
                     (max_width - min_width);
     coords[1] = param;
   }
   FXFT_Free(m_Face, pMasters);
   FXFT_Set_MM_Design_Coordinates(m_Face, 2, coords);
 }
@@ skipping 442 matching lines @@
 void _CFX_UniqueKeyGen::Generate(int count, ...) {
   va_list argList;
   va_start(argList, count);
   for (int i = 0; i < count; i++) {
     int p = va_arg(argList, int);
     ((FX_DWORD*)m_Key)[i] = p;
   }
   va_end(argList);
   m_KeyLen = count * sizeof(FX_DWORD);
 }