Issue 1409843002: Make Closure Compiler understand assertNotReached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409843002: Make Closure Compiler understand assertNotReached (Closed)

Created:
5 years, 2 months ago by Dan Beam

Modified:
5 years, 2 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make Closure Compiler understand assertNotReached This is a step toward enabling warning_level=VERBOSE because it fixes quite a few "Return missing" errors (see test case) R=tbreisacher@chromium.org BUG=543423 TEST=compiler_test.py Committed: https://chromium.googlesource.com/chromium/src/+/05d1fbd1ab064c7fe75ce228369bd67611323f9a

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -3 lines)			Patch
M	third_party/closure_compiler/compiler_test.py	View	2 chunks	+28 lines, -2 lines	0 comments	Download
M	third_party/closure_compiler/runner/runner.jar	View	Binary file		0 comments	Download
M	third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	ui/webui/resources/js/cr/ui/table.js	View	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

https://codereview.chromium.org/1409843002/diff/1/ui/webui/resources/js/cr/ui/table.js File ui/webui/resources/js/cr/ui/table.js (left): https://codereview.chromium.org/1409843002/diff/1/ui/webui/resources/js/cr/ui/table.js#oldcode221 ui/webui/resources/js/cr/ui/table.js:221: * @return {boolean} Whether any scrolling was needed. first ...

5 years, 2 months ago (2015-10-15 21:56:02 UTC) #1

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/05d1fbd1ab064c7fe75ce228369bd67611323f9a Cr-Commit-Position: refs/heads/master@{#354414}

5 years, 2 months ago (2015-10-16 00:46:50 UTC) #3

Dan Beam

5 years, 2 months ago (2015-10-16 00:47:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
05d1fbd1ab064c7fe75ce228369bd67611323f9a (presubmit successful).

Expand Messages | Collapse Messages