Make Closure Compiler understand assertNotReached

third_party/closure_compiler/compiler_test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from ast import literal_eval
 import os
 import tempfile
 import unittest
 
@@ skipping 38 matching lines @@
     out_file, out_map = self._createOutFiles()
     args = _COMMON_CLOSURE_ARGS + (closure_args or [])
 
     externs = [_POLYMER_EXTERNS, _CHROME_SEND_EXTERNS]
     found_errors, stderr = self._checker.check(file_path,
                                                externs=externs,
                                                out_file=out_file,
                                                closure_args=args)
     return found_errors, stderr, out_file, out_map
 
-  def _runCheckerTestExpectError(self, source_code, expected_error):
-    _, stderr, out_file, out_map = self._runChecker(source_code)
+  def _runCheckerTestExpectError(self, source_code, expected_error,
+                                 closure_args=None):
+    _, stderr, out_file, out_map = self._runChecker(source_code, closure_args)
 
     self.assertTrue(expected_error in stderr,
         msg="Expected chunk: \n%s\n\nOutput:\n%s\n" % (
             expected_error, stderr))
     self.assertFalse(os.path.exists(out_file))
     self.assertFalse(os.path.exists(out_map))
 
   def _runCheckerTestExpectSuccess(self, source_code, expected_output=None,
                                    closure_args=None):
     found_errors, stderr, out_file, out_map = self._runChecker(source_code,
@@ skipping 264 matching lines @@
 
   def testExportPathWithTargets(self):
     self._runCheckerTestExpectSuccess(self._CR_DEFINE_DEFINITION +
         "var path = 'a.b.c'; cr.exportPath(path, {}, {});")
 
   def testExportPathNoPath(self):
     self._runCheckerTestExpectError(self._CR_DEFINE_DEFINITION +
         "cr.exportPath();",
         "ERROR - cr.exportPath() should have at least 1 argument: path name")
 
+  def testMissingReturnAssertNotReached(self):
+    template = self._ASSERT_DEFINITION + """
+/** @enum {number} */
+var Enum = {FOO: 1, BAR: 2};
+
+/**
+ * @param {Enum} e
+ * @return {number}
+ */
+function enumToVal(e) {
+  switch (e) {
+    case Enum.FOO:
+      return 1;
+    case Enum.BAR:
+      return 2;
+  }
+  %s
+}
+"""
+    args = ['warning_level=VERBOSE']
+    self._runCheckerTestExpectError(template % '', 'Missing return',
+                                    closure_args=args)
+    self._runCheckerTestExpectSuccess(template % 'assertNotReached();',
+                                      closure_args=args)
+
 
 if __name__ == "__main__":
   unittest.main()