Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409803006: Rename apiimpl.Compiler to CompilerImpl. (Closed)

Created:
5 years, 1 month ago by sigurdm
Modified:
5 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -68 lines) Patch
M pkg/compiler/lib/compiler_new.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/apiimpl.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/analyze.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/dart2js_incremental/lib/dart2js_incremental.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/bad_loop_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/check_elements_invariants_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/codegen_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_mapping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/incremental/compile_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/library_resolution_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/memory_source_file_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_helper_rename_test.dart View 1 5 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mirror_helper_test.dart View 1 5 chunks +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mirror_helper_unique_minification_test.dart View 1 5 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/source_map_d2js_validity_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/source_map_deferred_d2js_validity_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/source_map_validator_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
sigurdm
5 years, 1 month ago (2015-10-29 08:42:33 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1409803006/diff/1/tests/compiler/dart2js/mirror_helper_rename_test.dart File tests/compiler/dart2js/mirror_helper_rename_test.dart (right): https://codereview.chromium.org/1409803006/diff/1/tests/compiler/dart2js/mirror_helper_rename_test.dart#newcode86 tests/compiler/dart2js/mirror_helper_rename_test.dart:86: CompilerImpl compiler = await run(useMirrorHelperLibrary: false, minify: minify); ...
5 years, 1 month ago (2015-10-29 10:45:45 UTC) #3
sigurdm
https://codereview.chromium.org/1409803006/diff/1/tests/compiler/dart2js/mirror_helper_rename_test.dart File tests/compiler/dart2js/mirror_helper_rename_test.dart (right): https://codereview.chromium.org/1409803006/diff/1/tests/compiler/dart2js/mirror_helper_rename_test.dart#newcode86 tests/compiler/dart2js/mirror_helper_rename_test.dart:86: CompilerImpl compiler = await run(useMirrorHelperLibrary: false, minify: minify); On ...
5 years, 1 month ago (2015-10-29 12:00:59 UTC) #4
sigurdm
5 years, 1 month ago (2015-10-29 12:24:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e3b926849f50de2099799853349ddc18ac22fa83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698