|
|
Created:
5 years, 2 months ago by nasko Modified:
5 years, 2 months ago Reviewers:
Charlie Reis CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable support for swapped out RenderFrame(Host)
Attempt at disabling swapped out RenderFrame(Host) usage. Bugs fixed
since last attempt:
https://crbug.com/541578
https://crbug.com/543226
https://crbug.com/544271
BUG=357747
Committed: https://crrev.com/0b480ba36c61900d2941897bc74f42c8e70fd5cd
Cr-Commit-Position: refs/heads/master@{#354663}
Patch Set 1 #Patch Set 2 : Rebase on ToT. #
Messages
Total messages: 21 (9 generated)
nasko@chromium.org changed reviewers: + creis@chromium.org
Hey Charlie, Can you LGTM this one ... again :). Thanks! Nasko
LGTM once those fixes are in!
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nasko@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org Link to the patchset: https://codereview.chromium.org/1409773004/#ps20001 (title: "Rebase on ToT.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Transient error: Invalid delimiter in "linux_site_isolation": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0b480ba36c61900d2941897bc74f42c8e70fd5cd Cr-Commit-Position: refs/heads/master@{#354663}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1409373006/ by nasko@chromium.org. The reason for reverting is: More bugs got exposed: https://crbug.com/543896 https://crbug.com/544755 https://crbug.com/544868 . |