Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1409773004: Disable support for swapped out RenderFrame(Host) (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable support for swapped out RenderFrame(Host) Attempt at disabling swapped out RenderFrame(Host) usage. Bugs fixed since last attempt: https://crbug.com/541578 https://crbug.com/543226 https://crbug.com/544271 BUG=357747 Committed: https://crrev.com/0b480ba36c61900d2941897bc74f42c8e70fd5cd Cr-Commit-Position: refs/heads/master@{#354663}

Patch Set 1 #

Patch Set 2 : Rebase on ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/site_isolation_policy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
nasko
Hey Charlie, Can you LGTM this one ... again :). Thanks! Nasko
5 years, 2 months ago (2015-10-15 22:36:24 UTC) #2
Charlie Reis
LGTM once those fixes are in!
5 years, 2 months ago (2015-10-15 22:57:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/1
5 years, 2 months ago (2015-10-16 02:51:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 04:04:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/20001
5 years, 2 months ago (2015-10-17 01:18:54 UTC) #10
commit-bot: I haz the power
Transient error: Invalid delimiter in "linux_site_isolation": Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
5 years, 2 months ago (2015-10-17 01:18:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/20001
5 years, 2 months ago (2015-10-17 01:27:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isolation/builds/409)
5 years, 2 months ago (2015-10-17 02:29:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409773004/20001
5 years, 2 months ago (2015-10-17 02:45:23 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-17 02:49:53 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0b480ba36c61900d2941897bc74f42c8e70fd5cd Cr-Commit-Position: refs/heads/master@{#354663}
5 years, 2 months ago (2015-10-17 02:50:35 UTC) #20
nasko
5 years, 2 months ago (2015-10-19 20:53:47 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1409373006/ by nasko@chromium.org.

The reason for reverting is: More bugs got exposed:

https://crbug.com/543896
https://crbug.com/544755
https://crbug.com/544868
.

Powered by Google App Engine
This is Rietveld 408576698