Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409753006: Add CFI Linux ToT builder. (Closed)

Created:
5 years, 1 month ago by pcc1
Modified:
5 years, 1 month ago
Reviewers:
Sergey Berezin, Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org, krasin1
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change category to clang tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 3 chunks +10 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +18 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux_ToT.json View 5 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pcc1
5 years, 1 month ago (2015-11-05 01:32:09 UTC) #2
Nico
lgtm I think the recipe stuff is noparent for some reason, so you need sergeyberenzin ...
5 years, 1 month ago (2015-11-05 02:11:07 UTC) #3
pcc1
sergeyberezin: PTAL https://codereview.chromium.org/1409753006/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/1409753006/diff/1/masters/master.chromium.fyi/master.cfg#newcode1608 masters/master.chromium.fyi/master.cfg:1608: 'category': 'chromium_cfi', On 2015/11/05 02:11:07, Nico wrote: ...
5 years, 1 month ago (2015-11-05 02:40:33 UTC) #5
Sergey Berezin
lgtm
5 years, 1 month ago (2015-11-06 00:07:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409753006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409753006/20001
5 years, 1 month ago (2015-11-06 02:45:12 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 02:47:48 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297475

Powered by Google App Engine
This is Rietveld 408576698