Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/roll_deps.py

Issue 140973003: roll_deps.py: Make default_bots_list a module-level variable (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/roll_deps.py
===================================================================
--- tools/roll_deps.py (revision 13199)
+++ tools/roll_deps.py (working copy)
@@ -30,6 +30,30 @@
import tempfile
+DEFAULT_BOTS_LIST = [
+ 'android_clang_dbg',
+ 'android_dbg',
+ 'android_rel',
+ 'cros_daisy',
+ 'linux',
+ 'linux_asan',
+ 'linux_chromeos',
+ 'linux_chromeos_asan',
+ 'linux_gpu',
+ 'linux_layout',
+ 'linux_layout_rel',
+ 'mac',
+ 'mac_asan',
+ 'mac_gpu',
+ 'mac_layout',
+ 'mac_layout_rel',
+ 'win',
+ 'win_gpu',
+ 'win_layout',
+ 'win_layout_rel',
+]
+
+
class DepsRollConfig(object):
"""Contains configuration options for this module.
@@ -84,29 +108,6 @@
Called by the main() function.
"""
- default_bots_list = [
- 'android_clang_dbg',
- 'android_dbg',
- 'android_rel',
- 'cros_daisy',
- 'linux',
- 'linux_asan',
- 'linux_chromeos',
- 'linux_chromeos_asan',
- 'linux_gpu',
- 'linux_layout',
- 'linux_layout_rel',
- 'mac',
- 'mac_asan',
- 'mac_gpu',
- 'mac_layout',
- 'mac_layout_rel',
- 'win',
- 'win_gpu',
- 'win_layout',
- 'win_layout_rel',
- ]
-
option_parser = optparse.OptionParser(usage=__doc__)
# Anyone using this script on a regular basis should set the
# CHROMIUM_CHECKOUT_PATH environment variable.
@@ -150,8 +151,8 @@
default_bots_help = (
'Comma-separated list of bots, defaults to a list of %d bots.'
' To skip `git cl try`, set this to an empty string.'
- % len(default_bots_list))
- default_bots = ','.join(default_bots_list)
+ % len(DEFAULT_BOTS_LIST))
+ default_bots = ','.join(DEFAULT_BOTS_LIST)
option_parser.add_option(
'', '--bots', help=default_bots_help, default=default_bots)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698