roll_deps.py: Make default_bots_list a module-level variable

tools/roll_deps.py

 #!/usr/bin/python2
 
 # Copyright 2014 Google Inc.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Skia's Chromium DEPS roll script.
 
 This script:
@@ skipping 12 matching lines @@
 
 import optparse
 import os
 import re
 import shutil
 import subprocess
 import sys
 import tempfile
 
 
+DEFAULT_BOTS_LIST = [
+    'android_clang_dbg',
+    'android_dbg',
+    'android_rel',
+    'cros_daisy',
+    'linux',
+    'linux_asan',
+    'linux_chromeos',
+    'linux_chromeos_asan',
+    'linux_gpu',
+    'linux_layout',
+    'linux_layout_rel',
+    'mac',
+    'mac_asan',
+    'mac_gpu',
+    'mac_layout',
+    'mac_layout_rel',
+    'win',
+    'win_gpu',
+    'win_layout',
+    'win_layout_rel',
+]
+
+
 class DepsRollConfig(object):
     """Contains configuration options for this module.
 
     Attributes:
         git: (string) The git executable.
         chromium_path: (string) path to a local chromium git repository.
         save_branches: (boolean) iff false, delete temporary branches.
         verbose: (boolean)  iff false, suppress the output from git-cl.
         search_depth: (int) how far back to look for the revision.
         skia_url: (string) Skia's git repository.
@@ skipping 34 matching lines @@
     @staticmethod
     def GetOptionParser():
         # pylint: disable=I0011,C0103
         """Returns an optparse.OptionParser object.
 
         Returns:
             An optparse.OptionParser object.
 
         Called by the main() function.
         """
-        default_bots_list = [
-            'android_clang_dbg',
-            'android_dbg',
-            'android_rel',
-            'cros_daisy',
-            'linux',
-            'linux_asan',
-            'linux_chromeos',
-            'linux_chromeos_asan',
-            'linux_gpu',
-            'linux_layout',
-            'linux_layout_rel',
-            'mac',
-            'mac_asan',
-            'mac_gpu',
-            'mac_layout',
-            'mac_layout_rel',
-            'win',
-            'win_gpu',
-            'win_layout',
-            'win_layout_rel',
-            ]
-
         option_parser = optparse.OptionParser(usage=__doc__)
         # Anyone using this script on a regular basis should set the
         # CHROMIUM_CHECKOUT_PATH environment variable.
         option_parser.add_option(
             '-c', '--chromium_path', help='Path to local Chromium Git'
             ' repository checkout, defaults to CHROMIUM_CHECKOUT_PATH'
             ' if that environment variable is set.',
             default=os.environ.get('CHROMIUM_CHECKOUT_PATH'))
         option_parser.add_option(
             '-r', '--revision', type='int', default=None,
@@ skipping 23 matching lines @@
             '', '--verbose', help='Do not suppress the output from `git cl`.',
             action='store_true', dest='verbose', default=False)
         option_parser.add_option(
             '', '--skip_cl_upload', help='Skip the cl upload step; useful'
             ' for testing or with --save_branches.',
             action='store_true', default=False)
 
         default_bots_help = (
             'Comma-separated list of bots, defaults to a list of %d bots.'
             '  To skip `git cl try`, set this to an empty string.'
-            % len(default_bots_list))
-        default_bots = ','.join(default_bots_list)
+            % len(DEFAULT_BOTS_LIST))
+        default_bots = ','.join(DEFAULT_BOTS_LIST)
         option_parser.add_option(
             '', '--bots', help=default_bots_help, default=default_bots)
 
         return option_parser
 
 
 def test_git_executable(git_executable):
     """Test the git executable.
 
     Args:
@@ skipping 649 matching lines @@
     if not test_git_executable(options.git_path):
         option_parser.error('Invalid git executable.')
 
     config = DepsRollConfig(options)
     find_hash_and_roll_deps(config, options.revision, options.git_hash)
 
 
 if __name__ == '__main__':
     main(sys.argv[1:])