Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 140973003: roll_deps.py: Make default_bots_list a module-level variable (Closed)

Created:
6 years, 10 months ago by borenet
Modified:
6 years, 10 months ago
Reviewers:
hal.canary
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

roll_deps.py: Make default_bots_list a module-level variable This allows us to import the script rather than run it in a sub-shell. BUG=skia: R=halcanary@google.com Committed: https://code.google.com/p/skia/source/detail?r=13200

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M tools/roll_deps.py View 1 3 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
borenet
6 years, 10 months ago (2014-01-27 17:58:43 UTC) #1
hal.canary
lgtm
6 years, 10 months ago (2014-01-27 18:05:59 UTC) #2
borenet
6 years, 10 months ago (2014-01-27 18:09:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13200.

Powered by Google App Engine
This is Rietveld 408576698