Issue 1409723007: Hack around TLS destructors firing after the process exits round 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409723007: Hack around TLS destructors firing after the process exits round 2 (Closed)

Created:
5 years, 1 month ago by Cutch

Modified:
5 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Hack around TLS destructors firing after the process exits round 2 - When a process exits on Windows, Windows closes all handles - Our mutexes use a handle to a semaphore for locking - If our TLS destructors need to take a lock during thread exit (but after process has started to shutdown) we will deadlock waiting on a handle that's been closed. This works around the problem by not running tls destructors when we are exiting the process. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/791941a1707d999d0945f9419103ace9a4db3f09

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -1 line)			Patch
M	runtime/bin/platform_win.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/run_vm_tests.cc	View	2 chunks	+8 lines, -1 line	1 comment	Download
M	runtime/vm/os_thread_win.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/thread_interrupter.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 (id:1) manually as 791941a1707d999d0945f9419103ace9a4db3f09 (presubmit successful).

5 years, 1 month ago (2015-11-04 14:55:18 UTC) #2

zra

5 years, 1 month ago (2015-11-04 15:04:45 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1409723007/diff/1/runtime/bin/run_vm_tests.cc
File runtime/bin/run_vm_tests.cc (right):

https://codereview.chromium.org/1409723007/diff/1/runtime/bin/run_vm_tests.cc...
runtime/bin/run_vm_tests.cc:129: private_flag_windows_run_tls_destructors =
false;
Oh, I guess this needs an #if defined(TARGET_OS_WIN) around it.

Expand Messages | Collapse Messages