Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: runtime/bin/platform_win.cc

Issue 1409723007: Hack around TLS destructors firing after the process exits round 2 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/run_vm_tests.cc » ('j') | runtime/bin/run_vm_tests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/platform_win.cc
diff --git a/runtime/bin/platform_win.cc b/runtime/bin/platform_win.cc
index dd0812fd59005145a688b26e4544bf7d6d45d41c..9b29cb726f51d06c72d96c90befd5e58dec16c6a 100644
--- a/runtime/bin/platform_win.cc
+++ b/runtime/bin/platform_win.cc
@@ -14,6 +14,10 @@
namespace dart {
+
+// Defined in vm/os_thread_win.cc
+extern bool private_flag_windows_run_tls_destructors;
+
namespace bin {
bool Platform::Initialize() {
@@ -106,6 +110,8 @@ char* Platform::ResolveExecutablePath() {
}
void Platform::Exit(int exit_code) {
+ // TODO(zra): Remove once VM shuts down cleanly.
+ ::dart::private_flag_windows_run_tls_destructors = false;
// On Windows we use ExitProcess so that threads can't clobber the exit_code.
// See: https://code.google.com/p/nativeclient/issues/detail?id=2870
::ExitProcess(exit_code);
« no previous file with comments | « no previous file | runtime/bin/run_vm_tests.cc » ('j') | runtime/bin/run_vm_tests.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698