Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1409693009: Fix leaking of RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index e5146f415d8201e860b63d368a8b865fbc381c49..047ee3a8dfbf13a14a576c3ca7e6a0b8f9b22947 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -167,6 +167,11 @@ class CONTENT_EXPORT RenderFrameImpl
CompositorDependencies* compositor_deps,
const FrameMsg_NewFrame_WidgetParams& params);
+ // Deletes a RenderFrame identified by |routing_id|. It must be used only
+ // for deleting a RenderFrame used for pending cross-process navigations.
+ // All other cases are handled through either detaching or swapping frames.
+ static void DeleteFrame(int routing_id);
+
// Returns the RenderFrameImpl for the given routing ID.
static RenderFrameImpl* FromRoutingID(int routing_id);

Powered by Google App Engine
This is Rietveld 408576698