Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: content/common/frame_messages.h

Issue 1409693009: Fix leaking of RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 0e0287497e6b1a3dd437e58dd355fda0ea43c865..21f23dea7aca1ad2de14c18560ce30f7a7c58fc9 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -480,6 +480,10 @@ IPC_MESSAGE_ROUTED1(FrameMsg_VisualStateRequest, uint64 /* id */)
// Instructs the renderer to create a new RenderFrame object.
IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params /* params */)
+// Instructs the renderer to delete the RenderFrame object identified by
Charlie Reis 2015/10/29 17:28:58 Maybe we should distinguish this from how RenderFr
dcheng 2015/10/29 18:50:52 Ah... this is going to be fun. We're going to add
nasko 2015/10/29 19:09:45 Unfortunately, I think you are right : (.
nasko 2015/10/29 19:09:45 Yes, indeed.
+// |routing_id|.
+IPC_MESSAGE_CONTROL1(FrameMsg_DeleteFrame, int /* routing_id */)
+
// Instructs the renderer to create a new RenderFrameProxy object with
// |routing_id|. |render_view_routing_id| identifies the
// RenderView to be associated with this proxy. The new proxy's opener should

Powered by Google App Engine
This is Rietveld 408576698