Use C++ implementation of Object.definePropert{y,ies}

Use C++ implementation of Object.definePropert{y,ies}

For now, only rewire builtins in v8natives.js to call the new runtime functions.

Committed: https://crrev.com/b2abc0e3ad4ce9dde8d66aab7aafae179e6948d4
Cr-Commit-Position: refs/heads/master@{#31413}

[Jakob Kummerow, 2015-10-15 13:54:26]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2015-10-15 13:54:26]

PTAL.

If this sticks, I'll rewire the API next.

https://codereview.chromium.org/1409613004/diff/1/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1409613004/diff/1/src/js/v8natives.js#newcode...
src/js/v8natives.js:1036: if (%_IsJSProxy(obj) || %IsObserved(obj)) {
This line is new; the body of the if-block is the original body of the function.

https://codereview.chromium.org/1409613004/diff/1/src/js/v8natives.js#newcode...
src/js/v8natives.js:1104: if (%_IsJSProxy(obj) || %_IsJSProxy(properties) ||
%IsObserved(obj)) {
Same here: this line is new, the body of the block is the old function body.

[Toon Verwaest, 2015-10-15 14:06:58]

lgtm

[Jakob Kummerow, 2015-10-15 15:24:38]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-10-15 15:24:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1409613004/#ps20001
(title: "fix TypeError message")

[commit-bot: I haz the power, 2015-10-15 15:24:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409613004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409613004/20001

[commit-bot: I haz the power, 2015-10-15 16:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 16:04:02]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/9638)

[Jakob Kummerow, 2015-10-15 17:08:55]

Argh, the native context might not be fully populated yet...

https://codereview.chromium.org/1409613004/diff/40001/src/property-descriptor.cc
File src/property-descriptor.cc (right):

https://codereview.chromium.org/1409613004/diff/40001/src/property-descriptor...
src/property-descriptor.cc:49: if (isolate->bootstrapper()->IsActive()) return
false;
Alternative fix:

Object* empty_prototype_map = isolate->native_context()->get(
    Context::OBJECT_FUNCTION_PROTOTYPE_MAP_INDEX);
if (!empty_prototype_map->IsMap() ||
    JSObject::cast(map->prototype())->map() !=
        Map::cast(empty_prototype_map)) {
  return false;
}

That trades the src/bootstrapper.h #include for a raw ->get(..._INDEX) access. I
think both fixes are ugly. Which one do you prefer? :-)

[Toon Verwaest, 2015-10-20 13:03:03]

lgtm

[Jakob Kummerow, 2015-10-20 13:08:14]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2015-10-20 13:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409613004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409613004/40001

[commit-bot: I haz the power, 2015-10-20 13:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 13:18:27]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Jakob Kummerow, 2015-10-20 13:52:16]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-10-20 13:52:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1409613004/#ps60001
(title: "fix GetKeys regression after df8970a8c")

[commit-bot: I haz the power, 2015-10-20 13:52:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409613004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409613004/60001

[commit-bot: I haz the power, 2015-10-20 14:29:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-20 14:29:48]

Patchset 4 (id:??) landed as
https://crrev.com/b2abc0e3ad4ce9dde8d66aab7aafae179e6948d4
Cr-Commit-Position: refs/heads/master@{#31413}

[Michael Achenbach, 2015-10-20 19:49:48]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1412893005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests. Please request
rebase upstream first if intended:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil...

One test times out now..