Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: test/cctest/test-api.cc

Issue 1409613004: Use C++ implementation of Object.definePropert{y,ies} (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix GetKeys regression after df8970a8c Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property-descriptor.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 7ba4a3c4a923de2f38d9aa8d2453d880a26a8b92..9cccd0f56acf46b5a34edf10158a8e0faf27a1d0 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -8728,9 +8728,10 @@ TEST(AccessControlES5) {
CHECK_EQ(42, g_echo_value);
v8::Handle<Value> value;
- CompileRun("Object.defineProperty(other, 'accessible_prop', {value: -1})");
- value = CompileRun("other.accessible_prop == 42");
+ CompileRun("Object.defineProperty(other, 'accessible_prop', {value: 43})");
+ value = CompileRun("other.accessible_prop == 43");
CHECK(value->IsTrue());
+ CHECK_EQ(43, g_echo_value); // Make sure we didn't overwrite the setter.
}
« no previous file with comments | « src/property-descriptor.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698