add alternative to isRect named asRect

add alternative to isRect named asRect

This defines yunchao's proposed interface in terms of
an existing implementation.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13183

[caryclark, 2014-01-23 16:04:44]

Here is Yunchao's proposed interface using the existing isRect() implementation.
The asRect() interface is more clear than the current isRect() interface. The
next step would be to deprecate isRect(closed, direction).

Yunchao, please use this as a starting point to add one or more test cases that
fail with this implementation.

[reed1, 2014-01-23 18:34:20]

https://codereview.chromium.org/140953003/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/140953003/diff/1/include/core/SkPath.h#newcod...
include/core/SkPath.h:567: /** Returns kFill_PathAsRect or kStroke_PathAsRect if
the path is a rect. If
I wonder if we want a different overall description...

Returns kFill or kStroke if drawing the path (either filled or stroked) will be
equivalent to filling/stroking the path's bounding rect.
(SkPath::getBounds())...

https://codereview.chromium.org/140953003/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/140953003/diff/1/src/core/SkPath.cpp#newcode509
src/core/SkPath.cpp:509: return (PathAsRect) (isRect(&isClosed, direction) +
isClosed);
If we're going to be tricky about selecting which enum, then I think we need
compile-asserts to ensure that the order remains what we're expecting.

[caryclark, 2014-01-23 19:03:23]

https://codereview.chromium.org/140953003/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/140953003/diff/1/include/core/SkPath.h#newcod...
include/core/SkPath.h:567: /** Returns kFill_PathAsRect or kStroke_PathAsRect if
the path is a rect. If
On 2014/01/23 18:34:20, reed1 wrote:
> I wonder if we want a different overall description...
> 
> Returns kFill or kStroke if drawing the path (either filled or stroked) will
be
> equivalent to filling/stroking the path's bounding rect.
> (SkPath::getBounds())...

Done.

https://codereview.chromium.org/140953003/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/140953003/diff/1/src/core/SkPath.cpp#newcode509
src/core/SkPath.cpp:509: return (PathAsRect) (isRect(&isClosed, direction) +
isClosed);
On 2014/01/23 18:34:20, reed1 wrote:
> If we're going to be tricky about selecting which enum, then I think we need
> compile-asserts to ensure that the order remains what we're expecting.

Done.

[reed1, 2014-01-23 19:14:15]

lgtm

[yunchao, 2014-01-24 14:49:15]

On 2014/01/23 16:04:44, caryclark wrote:
> Here is Yunchao's proposed interface using the existing isRect()
implementation.
> The asRect() interface is more clear than the current isRect() interface. The
> next step would be to deprecate isRect(closed, direction).
> 
> Yunchao, please use this as a starting point to add one or more test cases
that
> fail with this implementation.

lgtm

OK, I will check with test cases based on this CL.

[commit-bot: I haz the power, 2014-01-25 16:42:17]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/caryclark@google.com/140953003/70001

[commit-bot: I haz the power, 2014-01-25 16:54:34]

Change committed as 13183

[yunchao, 2014-02-08 06:59:31]

On 2014/01/25 16:54:34, I haz the power (commit-bot) wrote:
> Change committed as 13183

sorry to be late to check this CL with my previous test cases, because I am on
vacation for Chinese New Year last 2 weeks. please take a look at this CL:
https://codereview.chromium.org/138703008