Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 138703008: fix minor error between kStroke_PathAsRect and kFill_PathAsRect in SkPath::asRect (Closed)

Created:
6 years, 10 months ago by yunchao
Modified:
6 years, 10 months ago
Reviewers:
caryclark, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix minor error between kStroke_PathAsRect and kFill_PathAsRect in SkPath::asRect Committed: http://code.google.com/p/skia/source/detail?r=13390

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include/core/SkPath.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +2 lines, -2 lines 1 comment Download
M tests/PathTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yunchao
6 years, 10 months ago (2014-02-08 06:58:56 UTC) #1
yunchao
https://codereview.chromium.org/138703008/diff/1/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.chromium.org/138703008/diff/1/src/core/SkPath.cpp#newcode512 src/core/SkPath.cpp:512: return (PathAsRect) (isRect(&isClosed, direction) + isClosed); kFill_PathAsRect is added ...
6 years, 10 months ago (2014-02-08 07:10:48 UTC) #2
reed1
lgtm
6 years, 10 months ago (2014-02-10 13:15:35 UTC) #3
yunchao
The CQ bit was checked by yunchao.he@intel.com
6 years, 10 months ago (2014-02-11 01:25:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/138703008/1
6 years, 10 months ago (2014-02-11 01:25:46 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 01:38:32 UTC) #6
Message was sent while issue was closed.
Change committed as 13390

Powered by Google App Engine
This is Rietveld 408576698