CSS Font Loading: make FontFaceSet Setlike

third_party/WebKit/Source/core/css/FontFaceSet.idl

Index: third_party/WebKit/Source/core/css/FontFaceSet.idl
diff --git a/third_party/WebKit/Source/core/css/FontFaceSet.idl b/third_party/WebKit/Source/core/css/FontFaceSet.idl
index 50525e52f7b144de4d347bc4a3ab92f7f084668c..9e5fc9ccd048afb08ac246256b9d410eb16a9b05 100644
--- a/third_party/WebKit/Source/core/css/FontFaceSet.idl
+++ b/third_party/WebKit/Source/core/css/FontFaceSet.idl
@@ -39,10 +39,8 @@ enum FontFaceSetLoadStatus { "loading", "loaded" };
     SetWrapperReferenceFrom=document,
     NoInterfaceObject,
 ] interface FontFaceSet : EventTarget {
-    // TODO(ksakamoto): Make FontFaceSet Set-like. crbug.com/392075
-    // setlike<FontFace>;
-    void forEach(FontFaceSetForEachCallback callback, optional any thisArg);

[tkent, 2015/10/19 07:30:47]

forEach was already shipped, right?  We need UseCounter data and
intent-to-remove.

[Takashi Toyoshima, 2015/10/19 07:51:44]

It was shipped, but this change doesn't remove it.

The new line 'readonly setlike<FontFace>' automatically supplements it.
It is equivalent to following lines.

  void forEach(FontFaceSetForEachCallback callback, optional any thisArg);
  [RaiseException] boolean has(FontFace fontFace);
  [RaiseException] Iterator entries();
  [RaiseException] Iterator keys();
  [RaiseException] Iterator values();

So this change does not remove anything, but adds entries(), keys(), and
values().

They are tested by fontfaceset-set-operations.html I modified in this CL.

[tkent, 2015/10/19 07:59:53]

I see.  So, the web-exposed changes is trivial.  LGTM to ship.

-    [RaisesException] boolean has(FontFace fontFace);

[tkent, 2015/10/19 07:30:47]

Why do you remove |has| and rename C++ has to hasForBinding?

[Takashi Toyoshima, 2015/10/19 07:51:44]

Same. *forBinding is special method that is called auto-generated v8 binding
methods. They are mainly implemented in bindings/core/v8/Iterable.h and
FontFaceSet inherits it. Only FontFaceSet has to do is implement
startIteration(). Iterable.h does everything that are needed to implement
setlike related methods.

+    // TODO(toyoshim): Drop 'readonly' to use setlike's add, delete, and clear.
+    readonly setlike<FontFace>;
     readonly attribute unsigned long size;
     // TODO(philipj): add() should return the FontFaceSet.
     [RaisesException] void add(FontFace fontFace);