CSS Font Loading: make FontFaceSet Setlike

third_party/WebKit/Source/core/css/FontFaceSet.idl

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
 
 enum FontFaceSetLoadStatus { "loading", "loaded" };
 
 // TODO(philipj): This interface should be [Exposed=Window,Worker] and should
 // have a constructor, and thus not have [NoInterfaceObject].
 [
     ActiveDOMObject,
     SetWrapperReferenceFrom=document,
     NoInterfaceObject,
 ] interface FontFaceSet : EventTarget {
-    // TODO(ksakamoto): Make FontFaceSet Set-like. crbug.com/392075
-    // setlike<FontFace>;
-    void forEach(FontFaceSetForEachCallback callback, optional any thisArg);

[tkent, 2015/10/19 07:30:47]

forEach was already shipped, right?  We need UseCounter data and
intent-to-remove.

[Takashi Toyoshima, 2015/10/19 07:51:44]

It was shipped, but this change doesn't remove it.

The new line 'readonly setlike<FontFace>' automatically supplements it.
It is equivalent to following lines.

  void forEach(FontFaceSetForEachCallback callback, optional any thisArg);
  [RaiseException] boolean has(FontFace fontFace);
  [RaiseException] Iterator entries();
  [RaiseException] Iterator keys();
  [RaiseException] Iterator values();

So this change does not remove anything, but adds entries(), keys(), and
values().

They are tested by fontfaceset-set-operations.html I modified in this CL.

[tkent, 2015/10/19 07:59:53]

I see.  So, the web-exposed changes is trivial.  LGTM to ship.

-    [RaisesException] boolean has(FontFace fontFace);

[tkent, 2015/10/19 07:30:47]

Why do you remove |has| and rename C++ has to hasForBinding?

[Takashi Toyoshima, 2015/10/19 07:51:44]

Same. *forBinding is special method that is called auto-generated v8 binding
methods. They are mainly implemented in bindings/core/v8/Iterable.h and
FontFaceSet inherits it. Only FontFaceSet has to do is implement
startIteration(). Iterable.h does everything that are needed to implement
setlike related methods.

+    // TODO(toyoshim): Drop 'readonly' to use setlike's add, delete, and clear.
+    readonly setlike<FontFace>;
     readonly attribute unsigned long size;
     // TODO(philipj): add() should return the FontFaceSet.
     [RaisesException] void add(FontFace fontFace);
     [RaisesException, ImplementedAs=remove] boolean delete(FontFace fontFace);
     void clear();
 
     // events for when loading state changes
     attribute EventHandler onloading;
     attribute EventHandler onloadingdone;
     attribute EventHandler onloadingerror;
 
     // check and start loads if appropriate
     // and fulfill promise when all loads complete
     [CallWith=ScriptState] Promise<sequence<FontFace>> load(DOMString font, optional DOMString text = " ");
 
     // return whether all fonts in the fontlist are loaded
     // (does not initiate load if not available)
     [RaisesException] boolean check(DOMString font, optional DOMString text = " ");
 
     // async notification that font loading and layout operations are done
     [CallWith=ScriptState] readonly attribute Promise<FontFaceSet> ready;
 
     // loading state, "loading" while one or more fonts loading, "loaded" otherwise
     readonly attribute FontFaceSetLoadStatus status;
 };