src/hydrogen.cc - Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ports and addressed comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 41854088d31283f6bfa367e8a9eaa2b49b2c54de..a7bf85cfe82894007edcd0804365615dcd2fc29c 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5860,8 +5860,8 @@ void HOptimizedGraphBuilder::HandleGlobalVariableAssignment(

}

} else {

HGlobalObject* global_object = Add<HGlobalObject>();

- HStoreGlobalGeneric* instr =

- Add<HStoreGlobalGeneric>(global_object, var->name(),

+ HStoreNamedGeneric* instr =

+ Add<HStoreNamedGeneric>(global_object, var->name(),

value, function_strict_mode_flag());

USE(instr);

ASSERT(instr->HasObservableSideEffects());

« no previous file with comments | « src/full-codegen.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »