Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: src/hydrogen.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/full-codegen.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5842 matching lines...) Expand 10 before | Expand all | Expand 10 after
5853 Deoptimizer::EAGER); 5853 Deoptimizer::EAGER);
5854 builder.End(); 5854 builder.End();
5855 } 5855 }
5856 HInstruction* instr = 5856 HInstruction* instr =
5857 Add<HStoreGlobalCell>(value, cell, lookup.GetPropertyDetails()); 5857 Add<HStoreGlobalCell>(value, cell, lookup.GetPropertyDetails());
5858 if (instr->HasObservableSideEffects()) { 5858 if (instr->HasObservableSideEffects()) {
5859 Add<HSimulate>(ast_id, REMOVABLE_SIMULATE); 5859 Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
5860 } 5860 }
5861 } else { 5861 } else {
5862 HGlobalObject* global_object = Add<HGlobalObject>(); 5862 HGlobalObject* global_object = Add<HGlobalObject>();
5863 HStoreGlobalGeneric* instr = 5863 HStoreNamedGeneric* instr =
5864 Add<HStoreGlobalGeneric>(global_object, var->name(), 5864 Add<HStoreNamedGeneric>(global_object, var->name(),
5865 value, function_strict_mode_flag()); 5865 value, function_strict_mode_flag());
5866 USE(instr); 5866 USE(instr);
5867 ASSERT(instr->HasObservableSideEffects()); 5867 ASSERT(instr->HasObservableSideEffects());
5868 Add<HSimulate>(ast_id, REMOVABLE_SIMULATE); 5868 Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
5869 } 5869 }
5870 } 5870 }
5871 5871
5872 5872
5873 void HOptimizedGraphBuilder::HandleCompoundAssignment(Assignment* expr) { 5873 void HOptimizedGraphBuilder::HandleCompoundAssignment(Assignment* expr) {
5874 Expression* target = expr->target(); 5874 Expression* target = expr->target();
(...skipping 5120 matching lines...) Expand 10 before | Expand all | Expand 10 after
10995 if (ShouldProduceTraceOutput()) { 10995 if (ShouldProduceTraceOutput()) {
10996 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 10996 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
10997 } 10997 }
10998 10998
10999 #ifdef DEBUG 10999 #ifdef DEBUG
11000 graph_->Verify(false); // No full verify. 11000 graph_->Verify(false); // No full verify.
11001 #endif 11001 #endif
11002 } 11002 }
11003 11003
11004 } } // namespace v8::internal 11004 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/full-codegen.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698