Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409383002: Move widows/orphans property handling into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move widows/orphans property handling into CSSPropertyParser Move widows/orphans property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/fc3f6dc0c89b7ec08d5a9a624eee1734f2de5cdd Cr-Commit-Position: refs/heads/master@{#355290}

Patch Set 1 #

Patch Set 2 : widows orphans #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL
5 years, 2 months ago (2015-10-20 21:34:46 UTC) #3
Timothy Loh
lgtm https://codereview.chromium.org/1409383002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1409383002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode1207 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1207: if (range.peek().id() == CSSValueAuto) Probably should comment that ...
5 years, 2 months ago (2015-10-21 04:01:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409383002/40001
5 years, 2 months ago (2015-10-21 13:26:09 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-21 14:33:37 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 14:34:40 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fc3f6dc0c89b7ec08d5a9a624eee1734f2de5cdd
Cr-Commit-Position: refs/heads/master@{#355290}

Powered by Google App Engine
This is Rietveld 408576698