Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1409383002: Move widows/orphans property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index c85017d5769dda61640089b6c1bc3d9699d70636..1fc1c3fe89cd7b5152894cfdcde3bc4b866222b1 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -663,14 +663,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
validPrimitive = validUnit(value, FLength | FPercent | unitless);
break;
- case CSSPropertyOrphans: // <integer> | inherit | auto (We've added support for auto for backwards compatibility)
- case CSSPropertyWidows: // <integer> | inherit | auto (Ditto)
- if (id == CSSValueAuto)
- validPrimitive = true;
- else
- validPrimitive = validUnit(value, FPositiveInteger);
- break;
-
case CSSPropertyZIndex: // auto | <integer> | inherit
if (id == CSSValueAuto) {
validPrimitive = true;
@@ -1253,6 +1245,8 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyAnimationTimingFunction:
case CSSPropertyTransitionTimingFunction:
case CSSPropertyTransitionProperty:
+ case CSSPropertyOrphans:
+ case CSSPropertyWidows:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698