Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1409343009: New Mojom Parser: Make some getters and add a TODO. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom Parser: Make some getters and add a TODO. BUG=#461 R=azani@chromium.org, azani This is another trivial patch. I'm just adding a few getters to expose some more data to the serialization package. I also add a TODO to remind me that the current handling of attributes is not quite sufficient. Committed: https://chromium.googlesource.com/external/mojo/+/978f4c8fc3939db5d8e5c84142f83cb8228a8cb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M mojom/mojom_parser/mojom/types.go View 8 chunks +48 lines, -12 lines 0 comments Download
M mojom/mojom_parser/parser/parsing.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rudominer
ptal
5 years, 1 month ago (2015-11-03 22:03:23 UTC) #3
azani
lgtm
5 years, 1 month ago (2015-11-03 22:04:19 UTC) #4
rudominer
5 years, 1 month ago (2015-11-03 22:05:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
978f4c8fc3939db5d8e5c84142f83cb8228a8cb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698