Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: mojom/mojom_parser/parser/parsing.go

Issue 1409343009: New Mojom Parser: Make some getters and add a TODO. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojom/mojom_parser/mojom/types.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojom/mojom_parser/parser/parsing.go
diff --git a/mojom/mojom_parser/parser/parsing.go b/mojom/mojom_parser/parser/parsing.go
index e6abe75ca3fde176853216d7c23bdca54178d4b1..fde8e70173b863fcae8c57f71d0c92bf6490eaa2 100644
--- a/mojom/mojom_parser/parser/parsing.go
+++ b/mojom/mojom_parser/parser/parsing.go
@@ -295,6 +295,7 @@ func (p *Parser) parseAttributes() (attributes *mojom.Attributes) {
var value mojom.ConcreteValue
if p.peekNextToken("Expecting to find an attribute value.").Kind == lexer.Name {
text := p.readName()
+ // TODO(rudominer) Do not throw away the distinction between a name and a string literal.
value = mojom.MakeStringLiteralValue(text)
} else {
value = p.parseLiteral()
« no previous file with comments | « mojom/mojom_parser/mojom/types.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698