Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: sdk/lib/isolate/isolate.dart

Issue 1409343007: - Rollback packageConfig/File/Spec updates for 1.13. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/isolate_patch.dart ('k') | tests/isolate/package_map_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/isolate/isolate.dart
diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart
index 587a88ea983d5b034d718a1426fc38bc7a6f6072..8d284d23a10df287f882ab56add2f70ab35b862c 100644
--- a/sdk/lib/isolate/isolate.dart
+++ b/sdk/lib/isolate/isolate.dart
@@ -127,29 +127,6 @@ class Isolate {
external static Isolate get current;
/**
- * Returns the package root of the current isolate, if any.
- *
- * If the isolate is using a [packageMap], this getter returns `null`,
- * otherwise it returns the package root - a directory that package
- * URIs are resolved against.
- */
- external static Future<Uri> get packageRoot;
-
- /**
- * Returns the package mapping of the current isolate, if any.
- *
- * If the current isolate is using a [packageRoot], this getter
- * returns `null`.
- *
- * The package map maps the name of a package that is available to the
- * program, to a URI that package URIs for that package are resolved against.
- *
- * Returns an empty map if the isolate does not have a way to resolve package
- * URIs.
- */
- external static Future<Map<String, Uri>> get packageMap;
-
- /**
* Creates and spawns an isolate that shares the same code as the current
* isolate.
*
@@ -235,8 +212,8 @@ class Isolate {
*
* WARNING: The [checked] parameter is not implemented on all platforms yet.
*
- * If either the [packageRoot] or the [packageMap] parameter is provided,
- * it is used to find the location of package sources in the spawned isolate.
+ * If the [packageRoot] parameter is provided, it is used to find the location
+ * of package sources in the spawned isolate.
*
* The `packageRoot` URI must be a "file" or "http"/"https" URI that specifies
* a directory. If it doesn't end in a slash, one will be added before
@@ -245,21 +222,6 @@ class Isolate {
* resolved against this location, as by
* `packageRoot.resolve("foo/bar.dart")`.
*
- * The `packageMap` map maps package names to URIs with the same requirements
- * as `packageRoot`. Package imports (like `"package:foo/bar/baz.dart"`) in
- * the new isolate are resolved against the URI for that package (if any),
- * as by `packages["foo"].resolve("bar/baz.dart")
- *
- * This resolution also applies to the main entry [uri]
- * if that happens to be a package-URI.
- *
- * If both [packageRoot] and [packageMap] are omitted, the new isolate uses
- * the same package resolution as the current isolate.
- * It's not allowed to provide both a `packageRoot` and a `package` parameter.
- *
- * WARNING: The [packageRoot] and [packageMap] parameters are not implemented
- * on all platforms yet.
- *
* The [environment] is a mapping from strings to strings which the
* spawned isolate uses when looking up [String.fromEnvironment] values.
* The system may add its own entries to environment as well.
@@ -282,8 +244,7 @@ class Isolate {
bool errorsAreFatal,
bool checked,
Map<String, String> environment,
- Uri packageRoot,
- Map<String, Uri> packageMap});
+ Uri packageRoot});
/**
* Requests the isolate to pause.
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/isolate_patch.dart ('k') | tests/isolate/package_map_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698