Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart

Issue 1409343007: - Rollback packageConfig/File/Spec updates for 1.13. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/isolate/isolate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
index 655a51c472ad04b891b9c6e1196db128c036b1f4..ac8b5376327552810cd99fd3dbee3c95eabfbc7d 100644
--- a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
@@ -20,16 +20,6 @@ class Isolate {
static Isolate get current => _currentIsolateCache;
@patch
- static Future<Uri> get packageRoot {
- throw new UnsupportedError("Isolate.packageRoot");
- }
-
- @patch
- static Future<Map<String, Uri>> get packageMap {
- throw new UnsupportedError("Isolate.packageMap");
- }
-
- @patch
static Future<Isolate> spawn(void entryPoint(message), var message,
{bool paused: false, bool errorsAreFatal,
SendPort onExit, SendPort onError}) {
@@ -76,11 +66,9 @@ class Isolate {
bool errorsAreFatal,
bool checked,
Map<String, String> environment,
- Uri packageRoot,
- Map<String, Uri> packageMap}) {
+ Uri packageRoot}) {
if (environment != null) throw new UnimplementedError("environment");
if (packageRoot != null) throw new UnimplementedError("packageRoot");
- if (packageMap != null) throw new UnimplementedError("packageMap");
bool forcePause = (errorsAreFatal != null) ||
(onExit != null) ||
(onError != null);
@@ -94,7 +82,7 @@ class Isolate {
} else if (args != null) {
throw new ArgumentError("Args must be a list of Strings $args");
}
- // TODO: Handle [packageRoot]/[packages] somehow, possibly by throwing.
+ // TODO: Handle [packageRoot] somehow, possibly by throwing.
// TODO: Consider passing the errorsAreFatal/onExit/onError values
// as arguments to the internal spawnUri instead of setting
// them after the isolate has been created.
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/isolate/isolate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698