Add Token Binding to about:flags

Add Token Binding to about:flags

BUG=467312
Committed: https://crrev.com/ef2618645c67e096238ae7a26d6e9dde262f7da5
Cr-Commit-Position: refs/heads/master@{#373358}

[nharper, 2015-11-11 00:38:24]

nharper@chromium.org changed reviewers:
+ cbentzel@chromium.org

[nharper, 2015-11-11 00:38:24]

This CL is dependent on https://codereview.chromium.org/1378613004/.

[cbentzel, 2015-11-11 04:49:47]

This change also introduces a field trial. Any chance that could get moved to a
separate CL? If not, include it in the CL description. Thanks

[chromium-reviews, 2015-11-11 15:11:07]

We've recently added a new API in base/feature_list.h that's meant to
replace this kind of usage of both FieldTrial and CommandLine flags API.
Would you be interested in trying it out for this?

On Tue, Nov 10, 2015 at 11:49 PM, <cbentzel@chromium.org> wrote:

> This change also introduces a field trial. Any chance that could get moved
> to a
> separate CL? If not, include it in the CL description. Thanks
>
> https://codereview.chromium.org/1409323011/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cbentzel, 2015-12-01 01:14:12]

On 2015/11/11 15:11:07, chromium-reviews wrote:
> We've recently added a new API in base/feature_list.h that's meant to
> replace this kind of usage of both FieldTrial and CommandLine flags API.
> Would you be interested in trying it out for this?
> 
> On Tue, Nov 10, 2015 at 11:49 PM, <mailto:cbentzel@chromium.org> wrote:
> 
> > This change also introduces a field trial. Any chance that could get moved
> > to a
> > separate CL? If not, include it in the CL description. Thanks
> >
> > https://codereview.chromium.org/1409323011/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Just checking - am I holding up progress on this CL?

[cbentzel, 2015-12-01 01:14:13]

On 2015/11/11 15:11:07, chromium-reviews wrote:
> We've recently added a new API in base/feature_list.h that's meant to
> replace this kind of usage of both FieldTrial and CommandLine flags API.
> Would you be interested in trying it out for this?
> 
> On Tue, Nov 10, 2015 at 11:49 PM, <mailto:cbentzel@chromium.org> wrote:
> 
> > This change also introduces a field trial. Any chance that could get moved
> > to a
> > separate CL? If not, include it in the CL description. Thanks
> >
> > https://codereview.chromium.org/1409323011/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Just checking - am I holding up progress on this CL?

[nharper, 2015-12-01 17:03:18]

On 2015/12/01 01:14:13, cbentzel wrote:
> On 2015/11/11 15:11:07, chromium-reviews wrote:
> > We've recently added a new API in base/feature_list.h that's meant to
> > replace this kind of usage of both FieldTrial and CommandLine flags API.
> > Would you be interested in trying it out for this?
> > 
> > On Tue, Nov 10, 2015 at 11:49 PM, <mailto:cbentzel@chromium.org> wrote:
> > 
> > > This change also introduces a field trial. Any chance that could get moved
> > > to a
> > > separate CL? If not, include it in the CL description. Thanks
> > >
> > > https://codereview.chromium.org/1409323011/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> Just checking - am I holding up progress on this CL?

No. This is waiting on https://codereview.chromium.org/1378613004/ and is low
priority until we get the threat model figured out.

[nharper, 2016-01-26 21:49:46]

nharper@chromium.org changed reviewers:
+ jochen@chromium.org

[cbentzel, 2016-01-29 13:59:56]

LGTM

https://codereview.chromium.org/1409323011/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1409323011/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2148: IDS_FLAGS_ENABLE_TOKEN_BINDING_DESCRIPTION,
kOsAll,
Nit: Can you do one of these per line?

https://codereview.chromium.org/1409323011/diff/20001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1409323011/diff/20001/content/public/common/c...
content/public/common/content_features.cc:26: // Enableds token binding
(draft-ietf-tokbind-protocol-04).
Nit: typo on Enableds

You should provide a full URL to the draft.

[nharper, 2016-02-01 19:09:11]

fix nits

[nharper, 2016-02-01 19:28:53]

https://codereview.chromium.org/1409323011/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1409323011/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2148: IDS_FLAGS_ENABLE_TOKEN_BINDING_DESCRIPTION,
kOsAll,
On 2016/01/29 13:59:56, cbentzel wrote:
> Nit: Can you do one of these per line?

Done.

https://codereview.chromium.org/1409323011/diff/20001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1409323011/diff/20001/content/public/common/c...
content/public/common/content_features.cc:26: // Enableds token binding
(draft-ietf-tokbind-protocol-04).
On 2016/01/29 13:59:56, cbentzel wrote:
> Nit: typo on Enableds
> 
> You should provide a full URL to the draft.

Done.

[cbentzel, 2016-02-01 20:48:57]

LGTM

You'll need to get appropriate OWNERS to chime in.

https://codereview.chromium.org/1409323011/diff/40001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1409323011/diff/40001/content/public/common/c...
content/public/common/content_features.cc:27: //
(http://www.ietf.org/id/draft-ietf-tokbind-protocol-04.txt).
Nit: https URL works as well.

[nharper, 2016-02-01 21:03:35]

fix nit: http -> https

[nharper, 2016-02-01 22:17:07]

nharper@chromium.org changed reviewers:
+ davidben@chromium.org
- jochen@chromium.org

[nharper, 2016-02-01 22:17:08]

https://codereview.chromium.org/1409323011/diff/40001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1409323011/diff/40001/content/public/common/c...
content/public/common/content_features.cc:27: //
(http://www.ietf.org/id/draft-ietf-tokbind-protocol-04.txt).
On 2016/02/01 20:48:57, cbentzel wrote:
> Nit: https URL works as well. 

Done.

[davidben, 2016-02-03 20:46:45]

content lgtm

[nharper, 2016-02-03 20:47:37]

The CQ bit was checked by nharper@chromium.org

[nharper, 2016-02-03 20:47:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbentzel@chromium.org
Link to the patchset: https://codereview.chromium.org/1409323011/#ps60001
(title: "fix nit: http -> https")

[commit-bot: I haz the power, 2016-02-03 20:47:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409323011/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409323011/60001

[commit-bot: I haz the power, 2016-02-03 22:23:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-03 22:25:13]

Description was changed from

==========
Add Token Binding to about:flags

BUG=467312
==========

to

==========
Add Token Binding to about:flags

BUG=467312

Committed: https://crrev.com/ef2618645c67e096238ae7a26d6e9dde262f7da5
Cr-Commit-Position: refs/heads/master@{#373358}
==========

[commit-bot: I haz the power, 2016-02-03 22:25:13]

Patchset 4 (id:??) landed as
https://crrev.com/ef2618645c67e096238ae7a26d6e9dde262f7da5
Cr-Commit-Position: refs/heads/master@{#373358}