Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409223006: DevTools: replace content provider when re-adding into network project (Closed)

Created:
5 years, 1 month ago by pfeldman
Modified:
5 years, 1 month ago
Reviewers:
kozy, dgozman, sergeyv
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: replace content provider when re-adding into network project BUG=492902 Committed: https://crrev.com/73f121cf0649f7c9626446eaebc348e2845f41f8 Cr-Commit-Position: refs/heads/master@{#358926}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Same with isLiveEdit flag in a scriptParsed. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-with-same-source-url.html View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-with-same-source-url-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp View 1 2 3 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerListener.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerListener.cpp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProjectDelegate.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 2 7 chunks +13 lines, -11 lines 1 comment Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 1 2 3 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
5 years, 1 month ago (2015-11-10 06:45:11 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1409223006/diff/40001/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js File third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js (right): https://codereview.chromium.org/1409223006/diff/40001/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js#newcode275 third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js:275: if (!projectDelegate) How come you now need this ...
5 years, 1 month ago (2015-11-10 21:01:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409223006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409223006/40001
5 years, 1 month ago (2015-11-10 21:04:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 22:14:40 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 22:15:20 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/73f121cf0649f7c9626446eaebc348e2845f41f8
Cr-Commit-Position: refs/heads/master@{#358926}

Powered by Google App Engine
This is Rietveld 408576698