third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp - Issue 1409223006: DevTools: replace content provider when re-adding into network project

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

Issue 1409223006: DevTools: replace content provider when re-adding into network project (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Same with isLiveEdit flag in a scriptParsed. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-with-same-source-url-expected.txt ('k') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

index 5285c297265d5341b120cd279b4fb60ee62307cf..2a7121c57f8b7d4e7f6156de1a5e7ed8d8526f1c 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

@@ -1456,6 +1456,7 @@ void V8DebuggerAgentImpl::didParseSource(const ParsedScript& parsedScript)

bool isContentScript = script.isContentScript();

bool isInternalScript = script.isInternalScript();

+ bool isLiveEdit = script.isLiveEdit();

bool hasSourceURL = script.hasSourceURL();

String scriptURL = script.sourceURL();

String sourceMapURL = sourceMapURLForScript(script, parsedScript.compileResult);

@@ -1463,9 +1464,10 @@ void V8DebuggerAgentImpl::didParseSource(const ParsedScript& parsedScript)

const String* sourceMapURLParam = sourceMapURL.isNull() ? nullptr : &sourceMapURL;

const bool* isContentScriptParam = isContentScript ? &isContentScript : nullptr;

const bool* isInternalScriptParam = isInternalScript ? &isInternalScript : nullptr;

+ const bool* isLiveEditParam = isLiveEdit ? &isLiveEdit : nullptr;

const bool* hasSourceURLParam = hasSourceURL ? &hasSourceURL : nullptr;

if (!hasSyntaxError)

- m_frontend->scriptParsed(parsedScript.scriptId, scriptURL, script.startLine(), script.startColumn(), script.endLine(), script.endColumn(), isContentScriptParam, isInternalScriptParam, sourceMapURLParam, hasSourceURLParam);

+ m_frontend->scriptParsed(parsedScript.scriptId, scriptURL, script.startLine(), script.startColumn(), script.endLine(), script.endColumn(), isContentScriptParam, isInternalScriptParam, isLiveEditParam, sourceMapURLParam, hasSourceURLParam);

else

m_frontend->scriptFailedToParse(parsedScript.scriptId, scriptURL, script.startLine(), script.startColumn(), script.endLine(), script.endColumn(), isContentScriptParam, isInternalScriptParam, sourceMapURLParam, hasSourceURLParam);