Issue 1409173004: Remove usage of unsafe from gkvlite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409173004: Remove usage of unsafe from gkvlite (Closed)

Created:
5 years, 2 months ago by iannucci

Modified:
5 years, 2 months ago

Reviewers:
Vadim Sh.

CC:
chromium-reviews, infra-reviews+infra_chromium.org

Base URL:
https://chromium.googlesource.com/external/github.com/luci/gkvlite.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove usage of unsafe from gkvlite This will allow it to be used on appengine. R=vadimsh@chromium.org BUG=

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -85 lines)			Patch
M	alloc.go	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	collection.go	View		5 chunks	+4 lines, -7 lines	0 comments	Download
M	item.go	View	1	5 chunks	+39 lines, -14 lines	0 comments	Download
M	node.go	View		5 chunks	+36 lines, -14 lines	0 comments	Download
M	store.go	View		12 chunks	+46 lines, -25 lines	0 comments	Download
M	store_test.go	View		5 chunks	+14 lines, -14 lines	0 comments	Download
M	tools/slab/slab.go	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	tools/slab/slab_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Vadim Sh.

lgtm I wonder how much slower it become (or more memory hungry).

5 years, 2 months ago (2015-10-20 23:48:48 UTC) #2

iannucci

On 2015/10/20 at 23:48:48, vadimsh wrote: > lgtm > > I wonder how much slower ...

5 years, 2 months ago (2015-10-20 23:53:53 UTC) #3

iannucci

5 years, 2 months ago (2015-10-20 23:57:01 UTC) #4

Committed as
https://github.com/luci/gkvlite/commit/10bbae231193ace9d3c8969a194b425166b486e8