Remove usage of unsafe from gkvlite

tools/slab/slab.go

 package main
 
 // Test integration of gkvlite with go-slab, using gkvlite's optional
 // ItemAddRef/ItemDecRef() callbacks to integrate with a slab memory
 // allocator.
 
 import (
         "bytes"
         "flag"
         "fmt"
         "io"
         "log"
         "math/rand"
         "os"
         "sort"
         "testing"
-        "unsafe"
 
         "github.com/luci/gkvlite"
         "github.com/steveyen/go-slab"
 )
 
 var maxOps = flag.Int("ops", 0,
         "max number of ops; 0 means run forever")
 var maxItems = flag.Int("n", 10000,
         "max number of items")
 var maxItemBytes = flag.Int("maxItemBytes", 20000,
@@ skipping 132 matching lines @@
                 return nil
         }
         itemAlloc := func(c *gkvlite.Collection, keyLength uint32) *gkvlite.Item {
                 var n *ItemNode
                 if freeItemNodes != nil {
                         n = freeItemNodes
                         freeItemNodes = freeItemNodes.next
                         n.next = nil
                 } else {
                         n = &ItemNode{}
-                        n.item.Transient = unsafe.Pointer(n)
+                        n.item.Transient = n
                 }
                 if n.refs != 0 ||
                         n.item.Key != nil || n.item.Val != nil || n.item.Priority != 0 ||
-                        n.item.Transient != unsafe.Pointer(n) {
+                        n.item.Transient != n {
                         panic("unexpected ItemNode refs or item fields")
                 }
                 n.refs = 1
                 n.next = nil
                 n.item.Key = arena.Alloc(int(keyLength))
                 return &n.item
         }
         itemAddRef := func(c *gkvlite.Collection, i *gkvlite.Item) {
-                n := (*ItemNode)(i.Transient)
+                n := i.Transient.(*ItemNode)
                 n.refs++
         }
         itemDecRef := func(c *gkvlite.Collection, i *gkvlite.Item) {
-                n := (*ItemNode)(i.Transient)
+                n := i.Transient.(*ItemNode)
                 n.refs--
                 if n.refs == 0 {
                         if i.Key == nil {
                                 panic("expected a Key")
                         }
                         arena.DecRef(i.Key)
                         i.Key = nil
                         if i.Val != nil {
                                 arena.DecRef(i.Val)
                                 i.Val = nil
@@ skipping 153 matching lines @@
                                 for _, k := range mk {
                                         log.Printf("%s = %d", k, arenaStats[k])
                                 }
                         }
                         log.Printf("i: %d, numGets: %d, numSets: %d, numDeletes: %d"+
                                 ", numEvicts: %d, numReopens: %d, numFlushes: %d\n",
                                 i, numGets, numSets, numDeletes, numEvicts, numReopens, numFlushes)
                 }
         }
 }