Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
index 85a93a29edfb0c7e09712098f5a4ff0283a29887..384fed0e7421226c9176febc8173d71e66f89682 100644
--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc
@@ -13,6 +13,7 @@
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
#include "third_party/skia/include/core/SkBitmap.h"
using content::WebContents;
@@ -78,8 +79,9 @@ class LauncherFaviconLoaderBrowsertest
protected:
bool NavigateTo(const char* url) {
- std::string url_path = base::StringPrintf("files/ash/launcher/%s", url);
- ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(url_path));
+ std::string url_path = base::StringPrintf("/ash/launcher/%s", url);
+ ui_test_utils::NavigateToURL(browser(),
+ embedded_test_server()->GetURL(url_path));
return true;
}
@@ -125,7 +127,7 @@ class LauncherFaviconLoaderBrowsertest
};
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, SmallLauncherIcon) {
- ASSERT_TRUE(test_server()->Start());
+ ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-smallfavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
@@ -135,7 +137,7 @@ IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, SmallLauncherIcon) {
}
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, LargeLauncherIcon) {
- ASSERT_TRUE(test_server()->Start());
+ ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-largefavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
@@ -145,7 +147,7 @@ IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, LargeLauncherIcon) {
}
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ManyLauncherIcons) {
- ASSERT_TRUE(test_server()->Start());
+ ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-manyfavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());
@@ -158,7 +160,7 @@ IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ManyLauncherIcons) {
}
IN_PROC_BROWSER_TEST_F(LauncherFaviconLoaderBrowsertest, ChangeLauncherIcons) {
- ASSERT_TRUE(test_server()->Start());
+ ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(NavigateTo("launcher-manyfavicon.html"));
EXPECT_TRUE(WaitForContentsLoaded());
EXPECT_TRUE(WaitForFaviconUpdated());

Powered by Google App Engine
This is Rietveld 408576698