Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2414)

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc b/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
index e8160aa26c4f4d2874ffa1061e15b4ea178a4a7d..4bb888afe3e488d29a03d95fc6b5ef3e0c6c760e 100644
--- a/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
+++ b/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
@@ -28,7 +28,6 @@ using extensions::Manifest;
using net::test_server::BasicHttpResponse;
using net::test_server::HttpRequest;
using net::test_server::HttpResponse;
-using net::test_server::EmbeddedTestServer;
namespace app_list {
namespace test {
@@ -135,14 +134,12 @@ class WebstoreProviderTest : public InProcessBrowserTest {
// InProcessBrowserTest overrides:
void SetUpOnMainThread() override {
- test_server_.reset(new EmbeddedTestServer);
-
- ASSERT_TRUE(test_server_->InitializeAndWaitUntilReady());
- test_server_->RegisterRequestHandler(
+ embedded_test_server()->RegisterRequestHandler(
base::Bind(&WebstoreProviderTest::HandleRequest,
base::Unretained(this)));
+ ASSERT_TRUE(embedded_test_server()->Start());
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
- ::switches::kAppsGalleryURL, test_server_->base_url().spec());
+ ::switches::kAppsGalleryURL, embedded_test_server()->base_url().spec());
base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kEnableExperimentalAppList);
@@ -155,11 +152,6 @@ class WebstoreProviderTest : public InProcessBrowserTest {
webstore_provider_->set_use_throttling(false);
}
- void TearDownOnMainThread() override {
- EXPECT_TRUE(test_server_->ShutdownAndWaitUntilComplete());
- test_server_.reset();
- }
-
void RunQuery(const std::string& query,
const std::string& mock_server_response) {
mock_server_response_ = mock_server_response;
@@ -248,7 +240,6 @@ class WebstoreProviderTest : public InProcessBrowserTest {
run_loop_->Quit();
}
- scoped_ptr<EmbeddedTestServer> test_server_;
scoped_ptr<base::RunLoop> run_loop_;
std::string mock_server_response_;

Powered by Google App Engine
This is Rietveld 408576698