Issue 1409123004: Revert of Experimental CL to stop using subdata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409123004: Revert of Experimental CL to stop using subdata (Closed)

Created:
5 years, 2 months ago by joshualitt

Modified:
5 years, 2 months ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@bufferimpl2

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Experimental CL to stop using subdata (patchset #1 id:1 of https://codereview.chromium.org/1413263006/ ) Reason for revert: might be breaking tsan Original issue's description: > Experimental CL to stop using subdata > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/383ce32e3e5ca0c8997ece827205f61d348ee56f TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6df232d251cefe8f3498a1ae4dad449bafa9ebb3

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -1 line)			Patch
M	include/gpu/gl/GrGLConfig.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLBufferImpl.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLGpu.cpp	View	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of Experimental CL to stop using subdata

5 years, 2 months ago (2015-10-23 20:54:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409123004/1

5 years, 2 months ago (2015-10-23 20:54:07 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-23 20:54:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6df232d251cefe8f3498a1ae4dad449bafa9ebb3

Expand Messages | Collapse Messages